feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Add full stops to various error messages

Browse Source 
Change-Id: Ic4e07c5063a2e42af643faa4a5acb8445b12d6a1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
This commit is contained in:
Eike Ziller
2023-06-13 15:29:42 +02:00
parent 37433c1897
commit 33449bc880
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libs/utils/externalterminalprocessimpl.cpp
View File

@@ -61,7 +61,7 @@ expected_str<qint64> ProcessStubCreator::startStubProcess(const ProcessSetupData
QTemporaryFile *shFile = new QTemporaryFile(process); QTemporaryFile *shFile = new QTemporaryFile(process);
QTC_ASSERT(shFile->open(), QTC_ASSERT(shFile->open(),
return make_unexpected(Tr::tr("Failed to open temporary script file"))); return make_unexpected(Tr::tr("Failed to open temporary script file.")));
shFile->write(shScript.toUtf8()); shFile->write(shScript.toUtf8());
shFile->close(); shFile->close();
@@ -79,7 +79,7 @@ expected_str<qint64> ProcessStubCreator::startStubProcess(const ProcessSetupData
if (!process->waitForStarted()) { if (!process->waitForStarted()) {
return make_unexpected( return make_unexpected(
Tr::tr("Failed to start terminal process: \"%1\"").arg(process->errorString())); Tr::tr("Failed to start terminal process: \"%1\".").arg(process->errorString()));
} }
QObject::connect(process, &Process::done, m_interface, &TerminalInterface::onStubExited); QObject::connect(process, &Process::done, m_interface, &TerminalInterface::onStubExited);
@@ -115,7 +115,7 @@ expected_str<qint64> ProcessStubCreator::startStubProcess(const ProcessSetupData
process->waitForStarted(); process->waitForStarted();
if (process->error() != QProcess::UnknownError) { if (process->error() != QProcess::UnknownError) {
return make_unexpected( return make_unexpected(
Tr::tr("Failed to start terminal process: \"%1\"").arg(process->errorString())); Tr::tr("Failed to start terminal process: \"%1\".").arg(process->errorString()));
} }
qint64 pid = process->processId(); qint64 pid = process->processId();

6
src/libs/utils/filestreamermanager.cpp
View File

@@ -132,7 +132,7 @@ FileStreamHandle FileStreamerManager::copy(const FilePath &source, const FilePat
if (streamer->result() == StreamResult::FinishedWithSuccess) if (streamer->result() == StreamResult::FinishedWithSuccess)
cont({}); cont({});
else else
cont(make_unexpected(Tr::tr("Failed copying file"))); cont(make_unexpected(Tr::tr("Failed copying file.")));
}; };
return execute(onSetup, onDone, context); return execute(onSetup, onDone, context);
} }
@@ -156,7 +156,7 @@ FileStreamHandle FileStreamerManager::read(const FilePath &source, QObject *cont
if (streamer->result() == StreamResult::FinishedWithSuccess) if (streamer->result() == StreamResult::FinishedWithSuccess)
cont(streamer->readData()); cont(streamer->readData());
else else
cont(make_unexpected(Tr::tr("Failed reading file"))); cont(make_unexpected(Tr::tr("Failed reading file.")));
}; };
return execute(onSetup, onDone, context); return execute(onSetup, onDone, context);
} }
@@ -182,7 +182,7 @@ FileStreamHandle FileStreamerManager::write(const FilePath &destination, const Q
if (streamer->result() == StreamResult::FinishedWithSuccess) if (streamer->result() == StreamResult::FinishedWithSuccess)
cont(0); // TODO: return write count? cont(0); // TODO: return write count?
else else
cont(make_unexpected(Tr::tr("Failed writing file"))); cont(make_unexpected(Tr::tr("Failed writing file.")));
}; };
return execute(onSetup, onDone, context); return execute(onSetup, onDone, context);
} }

2
src/plugins/languageclient/languageclientsymbolsupport.cpp
View File

@@ -551,7 +551,7 @@ void SymbolSupport::handleRenameResponse(Core::SearchResult *search,
if (error.has_value()) { if (error.has_value()) {
errorMessage = error->toString(); errorMessage = error->toString();
if (errorMessage.contains("Cannot rename symbol: new name is the same as the old name")) if (errorMessage.contains("Cannot rename symbol: new name is the same as the old name"))
errorMessage = Tr::tr("Start typing to see replacements"); // clangd optimization errorMessage = Tr::tr("Start typing to see replacements."); // clangd optimization
else else
m_client->log(*error); m_client->log(*error);
} }

4
src/plugins/projectexplorer/copystep.cpp
View File

@@ -45,10 +45,10 @@ protected:
m_source.asyncCopy(m_target, this, [this](const expected_str<void> &cont) { m_source.asyncCopy(m_target, this, [this](const expected_str<void> &cont) {
if (!cont) { if (!cont) {
addOutput(cont.error(), OutputFormat::ErrorMessage); addOutput(cont.error(), OutputFormat::ErrorMessage);
addOutput(Tr::tr("Copying failed"), OutputFormat::ErrorMessage); addOutput(Tr::tr("Copying failed."), OutputFormat::ErrorMessage);
emit finished(false); emit finished(false);
} else { } else {
addOutput(Tr::tr("Copying finished"), OutputFormat::NormalMessage); addOutput(Tr::tr("Copying finished."), OutputFormat::NormalMessage);
emit finished(true); emit finished(true);
} }
}); });