From 33a38394b48462c819062b957f4e7495ee6863db Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 8 Apr 2021 12:22:06 +0200 Subject: [PATCH] Core: Consider keyboard navigation in output window scrolling logic ... by using QAbstractSlider::actionTriggered() instead of the mouse- centric signals. Fixes: QTCREATORBUG-25557 Change-Id: I0092fbfcb8fefb3a234bfb1592a2483bdc9e68d3 Reviewed-by: Orgad Shaneh --- src/plugins/coreplugin/outputwindow.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/plugins/coreplugin/outputwindow.cpp b/src/plugins/coreplugin/outputwindow.cpp index 2aeb9399bfc..7568ec3f368 100644 --- a/src/plugins/coreplugin/outputwindow.cpp +++ b/src/plugins/coreplugin/outputwindow.cpp @@ -153,9 +153,7 @@ OutputWindow::OutputWindow(Context context, const QString &settingsKey, QWidget EditorManager::openEditorAt(fp.toString(), line, column); }); - connect(verticalScrollBar(), &QAbstractSlider::sliderMoved, - this, &OutputWindow::updateAutoScroll); - connect(verticalScrollBar(), &QAbstractSlider::sliderReleased, + connect(verticalScrollBar(), &QAbstractSlider::actionTriggered, this, &OutputWindow::updateAutoScroll); undoAction->setEnabled(false); @@ -451,7 +449,7 @@ void OutputWindow::handleOutputChunk(const QString &output, OutputFormat format) void OutputWindow::updateAutoScroll() { - d->scrollToBottom = verticalScrollBar()->value() >= verticalScrollBar()->maximum() - 1; + d->scrollToBottom = verticalScrollBar()->sliderPosition() >= verticalScrollBar()->maximum() - 1; } void OutputWindow::setMaxCharCount(int count)