From 33badfa660f57fe62547f9c609d58088c2165280 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 6 Feb 2023 11:35:33 +0100 Subject: [PATCH] PathChooser: Don't leak menu Found by memory analyzer. Amends b3f82887a3ccc0a576a4720d8804ab99db7ae2b6 Change-Id: I580ab0873f5c3556445a87d9fc2c806eeb48c57e Reviewed-by: Marcus Tillmanns --- src/libs/utils/pathchooser.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libs/utils/pathchooser.cpp b/src/libs/utils/pathchooser.cpp index 84531ca5551..53825931b97 100644 --- a/src/libs/utils/pathchooser.cpp +++ b/src/libs/utils/pathchooser.cpp @@ -261,14 +261,14 @@ PathChooser::PathChooser(QWidget *parent) : d->m_hLayout->addWidget(d->m_lineEdit); d->m_hLayout->setSizeConstraint(QLayout::SetMinimumSize); + d->m_browseButton = new OptionPushButton; + d->m_browseButton->setText(browseButtonLabel()); + connect(d->m_browseButton, &OptionPushButton::clicked, this, [this] { slotBrowse(false); }); + d->m_contextMenu = new QMenu(d->m_browseButton); d->m_contextMenu->addAction(Tr::tr("Local"), this, [this] { slotBrowse(false); }); d->m_contextMenu->addAction(Tr::tr("Remote"), this, [this] { slotBrowse(true); }); - d->m_browseButton = new OptionPushButton(); - d->m_browseButton->setText(browseButtonLabel()); - connect(d->m_browseButton, &OptionPushButton::clicked, this, [this] { slotBrowse(false); }); - insertButton(d->m_buttons.count(), d->m_browseButton); setLayout(d->m_hLayout);