From 33ef73daf9f418239550fc95c1c64c02baf7ee08 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 9 Jan 2024 00:22:06 +0100 Subject: [PATCH] QtVersionManager: Make qtVersionsChanged args default Change-Id: Ifb420ebdeefe18114f82c48c2c4c49d808caef0c Reviewed-by: hjk --- src/plugins/qtsupport/qtversionmanager.cpp | 7 +++---- src/plugins/qtsupport/qtversionmanager.h | 3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/plugins/qtsupport/qtversionmanager.cpp b/src/plugins/qtsupport/qtversionmanager.cpp index 664eb8234d0..729ee215c6e 100644 --- a/src/plugins/qtsupport/qtversionmanager.cpp +++ b/src/plugins/qtsupport/qtversionmanager.cpp @@ -163,8 +163,7 @@ void QtVersionManagerImpl::triggerQtVersionRestore() NANOTRACE_SCOPE("QtSupport", "QtVersionManagerImpl::qtVersionsLoaded"); emit QtVersionManager::instance()->qtVersionsLoaded(); } - emit QtVersionManager::instance()->qtVersionsChanged( - m_versions.keys(), QList(), QList()); + emit QtVersionManager::instance()->qtVersionsChanged(m_versions.keys()); const FilePath configFileName = globalSettingsFileName(); if (configFileName.exists()) { @@ -478,7 +477,7 @@ void QtVersionManager::addVersion(QtVersion *version) int uniqueId = version->uniqueId(); m_versions.insert(uniqueId, version); - emit QtVersionManager::instance()->qtVersionsChanged(QList() << uniqueId, QList(), QList()); + emit QtVersionManager::instance()->qtVersionsChanged({uniqueId}); qtVersionManagerImpl().saveQtVersions(); } @@ -486,7 +485,7 @@ void QtVersionManager::removeVersion(QtVersion *version) { QTC_ASSERT(version, return); m_versions.remove(version->uniqueId()); - emit QtVersionManager::instance()->qtVersionsChanged(QList(), QList() << version->uniqueId(), QList()); + emit QtVersionManager::instance()->qtVersionsChanged({}, {version->uniqueId()}); qtVersionManagerImpl().saveQtVersions(); delete version; } diff --git a/src/plugins/qtsupport/qtversionmanager.h b/src/plugins/qtsupport/qtversionmanager.h index 7eb07310f87..6eba70fd334 100644 --- a/src/plugins/qtsupport/qtversionmanager.h +++ b/src/plugins/qtsupport/qtversionmanager.h @@ -43,7 +43,8 @@ public: signals: // content of QtVersion objects with qmake path might have changed - void qtVersionsChanged(const QList &addedIds, const QList &removedIds, const QList &changedIds); + void qtVersionsChanged(const QList &addedIds, const QList &removedIds = {}, + const QList &changedIds = {}); void qtVersionsLoaded(); private: