feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SshProcessInterface: Remove pidArgumentForKill()

Browse Source 
This interface method wasn't really sensible.

Change-Id: Ia47c893886ec06a2263b96d161578d46d2df5ffa
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-04-29 13:18:42 +02:00
parent 54628488a4
commit 340b61889d
7 changed files with 111 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/remotelinux/sshprocessinterface.h
View File

@@ -36,8 +36,6 @@ class SshProcessInterfacePrivate;
class REMOTELINUX_EXPORT SshProcessInterface : public Utils::ProcessInterface
{
Q_OBJECT
public:
SshProcessInterface(const LinuxDevice *linuxDevice);
~SshProcessInterface();
@@ -47,17 +45,18 @@ protected:
// To be called from leaf destructor.
// Can't call it from SshProcessInterface destructor as it calls virtual method.
void killIfRunning();
qint64 processId() const;
bool runInShell(const Utils::CommandLine &command, const QByteArray &data = {});
private:
virtual void handleStarted(qint64 processId);
virtual void handleReadyReadStandardOutput(const QByteArray &outputData);
virtual QString fullCommandLine(const Utils::CommandLine &commandLine) const = 0;
virtual QString pidArgumentForKill() const;
void start() final;
qint64 write(const QByteArray &data) final;
void sendControlSignal(Utils::ControlSignal controlSignal) final;
void sendControlSignal(Utils::ControlSignal controlSignal) override = 0;
bool waitForStarted(int msecs) final;
bool waitForReadyRead(int msecs) final;