feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SettingsDialog: Do not create widgets when looking for page with ID

Browse Source 
For pages that are not delayed additionally by an OptionsPageProvider,
we can just look for the ID without creating any widgets.

Task-number: QTCREATORBUG-15848
Change-Id: I118aa4713e76c8a43df7abad9f846e68105c659e
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Eike Ziller
2016-03-11 10:58:48 +01:00
parent 7cc1ee395d
commit 343242a988
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/coreplugin/dialogs/settingsdialog.cpp
View File

@@ -460,7 +460,6 @@ void SettingsDialog::showPage(const Id pageId)
for (int i = 0; i < categories.size(); ++i) {
Category *category = categories.at(i);
if (category->providers.isEmpty()) { // no providers
ensureCategoryWidget(category);
if (category->findPageById(initialPageId, &initialPageIndex)) {
initialCategoryIndex = i;
break;