feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: De-pimpl QmlProfilerViewManager

Browse Source 
The change is purely mechanical. QmlProfilerViewManager
is an internal class, not even extra #includes are needed.

Change-Id: Ia28b3a90c8c7dfeb1eb2510b4030c566bc264a46
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2017-06-27 16:14:24 +02:00
parent acd50cea8b
commit 345680a159
2 changed files with 41 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/plugins/qmlprofiler/qmlprofilerviewmanager.h
View File

@@ -28,12 +28,10 @@
#include "qmlprofilerstatisticsview.h"
#include "qmlprofilertraceview.h"
#include "flamegraphview.h"
#include <QObject>
namespace QmlProfiler {
class QmlProfilerModelManager;
class QmlProfilerStateManager;
namespace Internal {
class QmlProfilerTool;
@@ -41,19 +39,16 @@ class QmlProfilerTool;
class QmlProfilerViewManager : public QObject
{
Q_OBJECT
public:
explicit QmlProfilerViewManager(QObject *parent,
QmlProfilerModelManager *modelManager,
QmlProfilerStateManager *profilerState);
~QmlProfilerViewManager();
QmlProfilerViewManager(QObject *parent,
QmlProfilerModelManager *modelManager,
QmlProfilerStateManager *profilerState);
void createViews();
QmlProfilerTraceView *traceView() const { return m_traceView; }
QmlProfilerStatisticsView *statisticsView() const { return m_statisticsView; }
FlameGraphView *flameGraphView() const { return m_flameGraphView; }
QmlProfilerTraceView *traceView() const;
QmlProfilerStatisticsView *statisticsView() const;
FlameGraphView *flameGraphView() const;
public slots:
void clear();
signals:
@@ -61,8 +56,11 @@ signals:
void gotoSourceLocation(QString,int,int);
private:
class QmlProfilerViewManagerPrivate;
QmlProfilerViewManagerPrivate *d;
QmlProfilerTraceView *m_traceView = nullptr;
QmlProfilerStatisticsView *m_statisticsView = nullptr;
FlameGraphView *m_flameGraphView = nullptr;
QmlProfilerStateManager *m_profilerState = nullptr;
QmlProfilerModelManager *m_profilerModelManager = nullptr;
};