feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

C++: Fix weird logic in usage of TopLevelDeclarationProcessor::processDeclaration

Browse Source 
As the name function name suggests, true should be returned if the
declaration should be processed. Otherwise false.

Change-Id: I8d266d99c579b331fee8772bde47aa1a466dae9c
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
This commit is contained in:
Nikolai Kosjar
2014-03-13 10:58:18 -03:00
committed by Erik Verbruggen
parent 0832a0deac
commit 349de9331c
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/3rdparty/cplusplus/Parser.cpp vendored
View File

@@ -541,7 +541,7 @@ bool Parser::parseTranslationUnit(TranslationUnitAST *&node)
if (TopLevelDeclarationProcessor *processor = _control->topLevelDeclarationProcessor()) { if (TopLevelDeclarationProcessor *processor = _control->topLevelDeclarationProcessor()) {
if (processor->processDeclaration(declaration)) if (!processor->processDeclaration(declaration))
break; break;
} }

2
src/plugins/cpptools/cpptoolseditorsupport.cpp
View File

@@ -584,7 +584,7 @@ void CppEditorSupport::recalculateSemanticInfoDetached_helper(QFutureInterface<v
virtual ~TLDProc() {} virtual ~TLDProc() {}
virtual bool processDeclaration(DeclarationAST *ast) { virtual bool processDeclaration(DeclarationAST *ast) {
Q_UNUSED(ast); Q_UNUSED(ast);
return m_theFuture.isCanceled(); return !m_theFuture.isCanceled();
} }
}; };