From 34f48ea0c0a59c4be995a8a92171c7fd216fd59c Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Tue, 24 Jun 2014 12:20:13 +0200 Subject: [PATCH] QmlProfiler: improve location lookup a bit It's not a good idea to copy the event location for every single lookup and there is not point in always reconstructing the label strings, either. Change-Id: I2cea8a2a93b31d2c32bd2a27ae1d3b0bd26df6f6 Reviewed-by: Kai Koehne --- src/plugins/qmlprofiler/qmlprofilertimelinemodelproxy.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/qmlprofiler/qmlprofilertimelinemodelproxy.cpp b/src/plugins/qmlprofiler/qmlprofilertimelinemodelproxy.cpp index 4d454eaec34..68e6d8e1849 100644 --- a/src/plugins/qmlprofiler/qmlprofilertimelinemodelproxy.cpp +++ b/src/plugins/qmlprofiler/qmlprofilertimelinemodelproxy.cpp @@ -343,12 +343,12 @@ const QVariantMap RangeTimelineModel::getEventLocation(int index) const QVariantMap result; int eventId = getEventId(index); - QmlDebug::QmlEventLocation location + const QmlDebug::QmlEventLocation &location = d->modelManager->qmlModel()->getEventTypes().at(eventId).location; - result.insert(QLatin1String("file"), location.filename); - result.insert(QLatin1String("line"), location.line); - result.insert(QLatin1String("column"), location.column); + result.insert(QStringLiteral("file"), location.filename); + result.insert(QStringLiteral("line"), location.line); + result.insert(QStringLiteral("column"), location.column); return result; }