feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangSupport: Add 2 missing exports

Browse Source 
Fixes the following GCC warnings:

In file included from .../clangpchmanagerbackend/clangpchmanagerbackendmain.cpp:26:0:
.../clangsupport/clangpathwatcher.h: In instantiation of ‘class ClangBackEnd::ClangPathWatcher<QFileSystemWatcher, QTimer>’:
.../clangpchmanagerbackend/clangpchmanagerbackendmain.cpp:114:78:   required from here
.../clangsupport/clangpathwatcher.h:80:7: warning: ‘ClangBackEnd::ClangPathWatcher<QFileSystemWatcher, QTimer>’
    declared with greater visibility than the type of its field ‘ClangBackEnd::ClangPathWatcher<QFileSystemWatcher, QTimer>::m_idCache’ [-Wattributes]
 class ClangPathWatcher : public ClangPathWatcherInterface
       ^~~~~~~~~~~~~~~~

Change-Id: I8c6bc30e80da50b631d272ff7c2120cf706548aa
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
Orgad Shaneh
2018-01-16 21:59:40 +02:00
committed by Orgad Shaneh
parent a26fecf851
commit 351f355b69
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/clangsupport/clangpathwatcher.h
View File

@@ -77,7 +77,7 @@ using IdCache = StringCache<Utils::SmallString,
template <typename FileSystemWatcher, template <typename FileSystemWatcher,
typename Timer> typename Timer>
class ClangPathWatcher : public ClangPathWatcherInterface class CLANGSUPPORT_EXPORT ClangPathWatcher : public ClangPathWatcherInterface
{ {
public: public:
ClangPathWatcher(FilePathCachingInterface &pathCache, ClangPathWatcher(FilePathCachingInterface &pathCache,

2
src/libs/clangsupport/filepathcache.h
View File

@@ -36,7 +36,7 @@
namespace ClangBackEnd { namespace ClangBackEnd {
template <typename FilePathStorage> template <typename FilePathStorage>
class FilePathCache class CLANGSUPPORT_EXPORT FilePathCache
{ {
using DirectoryPathCache = StringCache<Utils::PathString, using DirectoryPathCache = StringCache<Utils::PathString,
int, int,