From 354abe5ad8a3bbcbaf28bb940395f67eca02b89d Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Wed, 13 Apr 2016 15:08:07 +0200 Subject: [PATCH] QmlJS: Fix possible crash For a valid AST id should be never empty. A crash has been reported. though. Most likely the parser injected a UiQualifiedId for an incomplete document. Change-Id: Id2f1b25cf9d78982524d7aaff2b43210e1ae2a3b Reviewed-by: Tim Jenssen --- src/libs/qmljs/qmljscheck.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libs/qmljs/qmljscheck.cpp b/src/libs/qmljs/qmljscheck.cpp index 3b77e623e9e..fbcb3ec0457 100644 --- a/src/libs/qmljs/qmljscheck.cpp +++ b/src/libs/qmljs/qmljscheck.cpp @@ -719,6 +719,10 @@ void Check::endVisit(UiObjectInitializer *) void Check::checkProperty(UiQualifiedId *qualifiedId) { const QString id = toString(qualifiedId); + + if (id.isEmpty()) + return; + if (id.at(0).isLower()) { if (m_propertyStack.top().contains(id)) addMessage(ErrPropertiesCanOnlyHaveOneBinding, fullLocationForQualifiedId(qualifiedId));