feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Sort targets in miniprojecttargetselector

Browse Source 
... based on their display names

Reviewed-by: Daniel Molkentin
This commit is contained in:
Tobias Hunger
2010-02-22 14:39:59 +01:00
parent e61c8238fb
commit 35bcc49bdf
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/projectexplorer/miniprojecttargetselector.cpp
View File

@@ -101,9 +101,10 @@ void ProjectListWidget::setBuildComboPopup()
void ProjectListWidget::setTarget(int index) void ProjectListWidget::setTarget(int index)
{ {
QList<Target *> targets(m_project->targets()); MiniTargetWidget *mtw = qobject_cast<MiniTargetWidget *>(itemWidget(item(index)));
if (index >= 0 && index < targets.count()) if (!mtw)
m_project->setActiveTarget(targets.at(index)); return;
m_project->setActiveTarget(mtw->target());
} }
MiniTargetWidget::MiniTargetWidget(Target *target, QWidget *parent) : MiniTargetWidget::MiniTargetWidget(Target *target, QWidget *parent) :
@@ -406,7 +407,20 @@ void MiniProjectTargetSelector::addTarget(ProjectExplorer::Target *target, bool
ProjectListWidget *plw = qobject_cast<ProjectListWidget*>(m_widgetStack->widget(index)); ProjectListWidget *plw = qobject_cast<ProjectListWidget*>(m_widgetStack->widget(index));
QListWidgetItem *lwi = new QListWidgetItem(); QListWidgetItem *lwi = new QListWidgetItem();
plw->addItem(lwi);
// Sort on insert:
for (int idx = 0; idx <= plw->count(); ++idx) {
QListWidgetItem *itm(plw->item(idx));
MiniTargetWidget *mtw(qobject_cast<MiniTargetWidget *>(plw->itemWidget(itm)));
if (!mtw && idx < plw->count())
continue;
if (idx == plw->count() ||
mtw->target()->displayName() > target->displayName()) {
plw->insertItem(idx, lwi);
break;
}
}
MiniTargetWidget *targetWidget = new MiniTargetWidget(target); MiniTargetWidget *targetWidget = new MiniTargetWidget(target);
connect(targetWidget, SIGNAL(changed()), this, SLOT(updateAction())); connect(targetWidget, SIGNAL(changed()), this, SLOT(updateAction()));
targetWidget->installEventFilter(this); targetWidget->installEventFilter(this);