diff --git a/src/libs/qmljs/qmljsmodelmanagerinterface.cpp b/src/libs/qmljs/qmljsmodelmanagerinterface.cpp index 067a42e4a11..3fcdb4be556 100644 --- a/src/libs/qmljs/qmljsmodelmanagerinterface.cpp +++ b/src/libs/qmljs/qmljsmodelmanagerinterface.cpp @@ -1000,7 +1000,7 @@ void ModelManagerInterface::importScan(QFutureInterface &future, QStringList subDirs(dir.entryList(QDir::Dirs | QDir::NoDotAndDotDot)); workDone += 1; totalWork += pathBudget / 2 * subDirs.size() - pathBudget * 3 / 4 + 1; - foreach (const QString path, subDirs) + foreach (const QString &path, subDirs) pathsToScan.append(ScanItem(dir.absoluteFilePath(path), toScan.depth + 1)); } else { workDone += pathBudget * 3 / 4; @@ -1040,7 +1040,7 @@ void ModelManagerInterface::maybeScan(const QStringList &importPaths, QStringList pathToScan; { QMutexLocker l(&m_mutex); - foreach (QString importPath, importPaths) + foreach (const QString &importPath, importPaths) if (!m_scannedPaths.contains(importPath)) { pathToScan.append(importPath); } diff --git a/src/plugins/android/androiddeployqtstep.cpp b/src/plugins/android/androiddeployqtstep.cpp index 75a7079805f..8f119ebb2e1 100644 --- a/src/plugins/android/androiddeployqtstep.cpp +++ b/src/plugins/android/androiddeployqtstep.cpp @@ -247,7 +247,7 @@ void AndroidDeployQtStep::run(QFutureInterface &fi) ProjectExplorer::ProcessParameters *pp = processParameters(); QString args; - foreach (const QString arg, AndroidDeviceInfo::adbSelector(m_serialNumber)) + foreach (const QString &arg, AndroidDeviceInfo::adbSelector(m_serialNumber)) Utils::QtcProcess::addArg(&args, arg); Utils::QtcProcess::addArg(&args, QLatin1String("install")); diff --git a/src/plugins/beautifier/abstractsettings.cpp b/src/plugins/beautifier/abstractsettings.cpp index 774478edafa..bf164cef28b 100644 --- a/src/plugins/beautifier/abstractsettings.cpp +++ b/src/plugins/beautifier/abstractsettings.cpp @@ -196,7 +196,7 @@ void AbstractSettings::save() } // remove old files - foreach (const QString file, m_stylesToRemove) + foreach (const QString &file, m_stylesToRemove) m_styleDir.remove(file); m_stylesToRemove.clear(); @@ -239,7 +239,7 @@ void AbstractSettings::read() s->beginGroup(QLatin1String(Constants::SETTINGS_GROUP)); s->beginGroup(m_name); const QStringList keys = s->allKeys(); - foreach (const QString key, keys) { + foreach (const QString &key, keys) { if (key == QLatin1String("command")) setCommand(s->value(key).toString()); else if (m_settings.contains(key)) @@ -259,7 +259,7 @@ void AbstractSettings::read() const QStringList files = m_styleDir.entryList(QStringList() << QLatin1Char('*') + m_ending, QDir::Files | QDir::Readable | QDir::NoDotAndDotDot); - foreach (const QString filename, files) { + foreach (const QString &filename, files) { // do not allow empty file names if (filename == m_ending) continue; diff --git a/src/plugins/clearcase/activityselector.cpp b/src/plugins/clearcase/activityselector.cpp index 3b78094e610..c7dbf9d03e2 100644 --- a/src/plugins/clearcase/activityselector.cpp +++ b/src/plugins/clearcase/activityselector.cpp @@ -87,7 +87,7 @@ bool ActivitySelector::refresh() int current; QList activities = m_plugin->activities(¤t); m_cmbActivity->clear(); - foreach (QStringPair activity, activities) + foreach (const QStringPair &activity, activities) m_cmbActivity->addItem(activity.second, activity.first); m_cmbActivity->setCurrentIndex(current); m_cmbActivity->updateGeometry(); diff --git a/src/plugins/cmakeprojectmanager/makestep.cpp b/src/plugins/cmakeprojectmanager/makestep.cpp index b81d8889a87..2ae6f755f57 100644 --- a/src/plugins/cmakeprojectmanager/makestep.cpp +++ b/src/plugins/cmakeprojectmanager/makestep.cpp @@ -140,7 +140,7 @@ void MakeStep::activeBuildConfigurationChanged() void MakeStep::buildTargetsChanged() { QStringList filteredTargets; - foreach (const QString t, static_cast(project())->buildTargetTitles()) { + foreach (const QString &t, static_cast(project())->buildTargetTitles()) { if (m_buildTargets.contains(t)) filteredTargets.append(t); } diff --git a/src/plugins/qmakeprojectmanager/qmakenodes.cpp b/src/plugins/qmakeprojectmanager/qmakenodes.cpp index d1180df1349..cb8052a5dd1 100644 --- a/src/plugins/qmakeprojectmanager/qmakenodes.cpp +++ b/src/plugins/qmakeprojectmanager/qmakenodes.cpp @@ -978,7 +978,7 @@ bool QmakePriFileNode::addFiles(const QStringList &filePaths, QStringList *notAd typedef QMap TypeFileMap; // Split into lists by file type and bulk-add them. TypeFileMap typeFileMap; - foreach (const QString file, filePaths) { + foreach (const QString &file, filePaths) { const Core::MimeType mt = Core::MimeDatabase::findByFile(file); typeFileMap[mt.type()] << file; } @@ -1025,7 +1025,7 @@ bool QmakePriFileNode::removeFiles(const QStringList &filePaths, typedef QMap TypeFileMap; // Split into lists by file type and bulk-add them. TypeFileMap typeFileMap; - foreach (const QString file, filePaths) { + foreach (const QString &file, filePaths) { const Core::MimeType mt = Core::MimeDatabase::findByFile(file); typeFileMap[mt.type()] << file; } diff --git a/src/plugins/qnx/blackberrysigningutils.cpp b/src/plugins/qnx/blackberrysigningutils.cpp index 300ab06195f..6699443f1e0 100644 --- a/src/plugins/qnx/blackberrysigningutils.cpp +++ b/src/plugins/qnx/blackberrysigningutils.cpp @@ -244,7 +244,7 @@ void BlackBerrySigningUtils::saveDebugTokens() settings->beginGroup(DebugTokensGroup); int count = 0; - foreach (QString dt, m_debugTokens) { + foreach (const QString &dt, m_debugTokens) { settings->beginGroup(QString::fromLatin1("debugToken_%1").arg(++count)); settings->setValue(DebugTokensPath, dt); settings->endGroup(); diff --git a/src/plugins/qnx/cascadesimport/projectfileconverter.cpp b/src/plugins/qnx/cascadesimport/projectfileconverter.cpp index bc6f588be72..46eb87c0315 100644 --- a/src/plugins/qnx/cascadesimport/projectfileconverter.cpp +++ b/src/plugins/qnx/cascadesimport/projectfileconverter.cpp @@ -94,11 +94,11 @@ static QString updateVariable(const QString &varStr, const QString &varsToAdd, QSet var = parseVariable(varStr); QSet ss = parseVariable(varsToAdd); - foreach (QString s, ss) + foreach (const QString &s, ss) var << s; ss = parseVariable(varsToRemove); - foreach (QString s, ss) + foreach (const QString &s, ss) var.remove(s); QStringList sl = QStringList::fromSet(var); diff --git a/src/plugins/winrt/winrtpackagedeploymentstep.cpp b/src/plugins/winrt/winrtpackagedeploymentstep.cpp index 409719d492a..f5aa28c2e5d 100644 --- a/src/plugins/winrt/winrtpackagedeploymentstep.cpp +++ b/src/plugins/winrt/winrtpackagedeploymentstep.cpp @@ -96,7 +96,7 @@ bool WinRtPackageDeploymentStep::init() raiseError(tr("Cannot parse manifest file %1.").arg(fullManifestPath)); return false; } - foreach (QString icon, iconsToDeploy) { + foreach (const QString &icon, iconsToDeploy) { m_mappingFileContent += QLatin1Char('"') + QDir::toNativeSeparators(targetDir + icon) + QLatin1String("\" \"") + QDir::toNativeSeparators(icon) + QLatin1String("\"\n");