From 3669566b01062dc09d5b5cefcce10ad7c6bf85c5 Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Mon, 21 Feb 2011 16:12:35 +0100 Subject: [PATCH] Debugger[CDB]: Do not dump symbols with memory-read-error. Fix a potential crash when accessing their nodes. --- src/libs/qtcreatorcdbext/symbolgroupvalue.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libs/qtcreatorcdbext/symbolgroupvalue.cpp b/src/libs/qtcreatorcdbext/symbolgroupvalue.cpp index 392f7878ac9..0c40227567f 100644 --- a/src/libs/qtcreatorcdbext/symbolgroupvalue.cpp +++ b/src/libs/qtcreatorcdbext/symbolgroupvalue.cpp @@ -1694,6 +1694,8 @@ unsigned dumpSimpleType(SymbolGroupNode *n, const SymbolGroupValueContext &ctx, // Prefix by pointer value const SymbolGroupValue v(n, ctx); + if (!v) // Value as such has memory read error? + return SymbolGroupNode::SimpleDumperFailed; if (SymbolGroupValue::isPointerType(v.type())) if (const ULONG64 pointerValue = v.pointerValue()) str << std::showbase << std::hex << pointerValue << std::dec << std::noshowbase << ' ';