feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger[CDB]: Do not dump symbols with memory-read-error.

Browse Source 
Fix a potential crash when accessing their nodes.
This commit is contained in:
Friedemann Kleint
2011-02-21 16:12:35 +01:00
parent c3a6a3eb06
commit 3669566b01
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/qtcreatorcdbext/symbolgroupvalue.cpp
View File

@@ -1694,6 +1694,8 @@ unsigned dumpSimpleType(SymbolGroupNode *n, const SymbolGroupValueContext &ctx,
// Prefix by pointer value // Prefix by pointer value
const SymbolGroupValue v(n, ctx); const SymbolGroupValue v(n, ctx);
if (!v) // Value as such has memory read error?
return SymbolGroupNode::SimpleDumperFailed;
if (SymbolGroupValue::isPointerType(v.type())) if (SymbolGroupValue::isPointerType(v.type()))
if (const ULONG64 pointerValue = v.pointerValue()) if (const ULONG64 pointerValue = v.pointerValue())
str << std::showbase << std::hex << pointerValue << std::dec << std::noshowbase << ' '; str << std::showbase << std::hex << pointerValue << std::dec << std::noshowbase << ' ';