feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

RunConfiguration: Centralize enabled state handling

Browse Source 
Centralize handling of enabled state of RunConfiguration widgets.

Remove code that does the same thing in all the different run configuration
widgets.

Change-Id: I175d7e19d031bd28a2b19cd825e0b6568da19bc3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Tobias Hunger
2017-07-17 16:54:13 +02:00
parent 131c7a1c4e
commit 366ada9fea
15 changed files with 39 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/qbsprojectmanager/qbsrunconfiguration.cpp
View File

@@ -313,17 +313,6 @@ QbsRunConfigurationWidget::QbsRunConfigurationWidget(QbsRunConfiguration *rc)
auto vboxTopLayout = new QVBoxLayout(this);
vboxTopLayout->setMargin(0);
auto hl = new QHBoxLayout();
hl->addStretch();
m_disabledIcon = new QLabel(this);
m_disabledIcon->setPixmap(Utils::Icons::WARNING.pixmap());
hl->addWidget(m_disabledIcon);
m_disabledReason = new QLabel(this);
m_disabledReason->setVisible(false);
hl->addWidget(m_disabledReason);
hl->addStretch();
vboxTopLayout->addLayout(hl);
auto detailsContainer = new Utils::DetailsWidget(this);
detailsContainer->setState(Utils::DetailsWidget::NoSummary);
vboxTopLayout->addWidget(detailsContainer);
@@ -343,23 +332,11 @@ QbsRunConfigurationWidget::QbsRunConfigurationWidget(QbsRunConfiguration *rc)
m_rc->extraAspect<TerminalAspect>()->addToMainConfigurationWidget(this, toplayout);
runConfigurationEnabledChange();
connect(m_rc, &QbsRunConfiguration::targetInformationChanged,
this, &QbsRunConfigurationWidget::targetInformationHasChanged, Qt::QueuedConnection);
connect(m_rc, &RunConfiguration::enabledChanged,
this, &QbsRunConfigurationWidget::runConfigurationEnabledChange);
}
void QbsRunConfigurationWidget::runConfigurationEnabledChange()
{
bool enabled = m_rc->isEnabled();
m_disabledIcon->setVisible(!enabled);
m_disabledReason->setVisible(!enabled);
m_disabledReason->setText(m_rc->disabledReason());
targetInformationHasChanged();
this, &QbsRunConfigurationWidget::targetInformationHasChanged);
}
void QbsRunConfigurationWidget::targetInformationHasChanged()