feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Finish merging Runnable and StandardRunnable

Browse Source 
As all Runnables are known to be StandardRunnables, this here
essentially replaces all .is<StandardRunnable> by 'true'.
.as<StandardRunnable> by no-op, and fixes the fallout.

Change-Id: I1632f8e164fa0a9dff063df47a9e191fdf7bbb2e
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-05-16 15:42:03 +02:00
parent fdccc54275
commit 36b835ff0a
73 changed files with 147 additions and 286 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/valgrind/valgrindengine.cpp
View File

@@ -83,8 +83,7 @@ void ValgrindToolRunner::start()
m_runner.setValgrindExecutable(m_settings->valgrindExecutable());
m_runner.setValgrindArguments(genericToolArguments() + toolArguments());
m_runner.setDevice(device());
QTC_ASSERT(runnable().is<StandardRunnable>(), reportFailure());
m_runner.setDebuggee(runnable().as<StandardRunnable>());
m_runner.setDebuggee(runnable());
connect(&m_runner, &ValgrindRunner::processOutputReceived,
this, &ValgrindToolRunner::receiveProcessOutput);
@@ -114,8 +113,7 @@ void ValgrindToolRunner::stop()
QString ValgrindToolRunner::executable() const
{
QTC_ASSERT(runnable().is<StandardRunnable>(), return QString());
return runnable().as<StandardRunnable>().executable;
return runnable().executable;
}
QStringList ValgrindToolRunner::genericToolArguments() const