diff --git a/src/libs/utils/devicefileaccess.cpp b/src/libs/utils/devicefileaccess.cpp index acf5edc0bf6..0814cc29ff8 100644 --- a/src/libs/utils/devicefileaccess.cpp +++ b/src/libs/utils/devicefileaccess.cpp @@ -560,7 +560,8 @@ bool DesktopDeviceFileAccess::writeFileContents( qint64 offset) const { QFile file(filePath.path()); - QTC_ASSERT(file.open(QFile::WriteOnly | QFile::Truncate), return false); + const bool isOpened = file.open(QFile::WriteOnly | QFile::Truncate); + QTC_ASSERT(isOpened, return false); if (offset != 0) file.seek(offset); qint64 res = file.write(data); diff --git a/src/libs/utils/fsengine/fsengine_impl.cpp b/src/libs/utils/fsengine/fsengine_impl.cpp index e09bc94609e..4436f4a3cdc 100644 --- a/src/libs/utils/fsengine/fsengine_impl.cpp +++ b/src/libs/utils/fsengine/fsengine_impl.cpp @@ -48,7 +48,8 @@ bool FSEngineImpl::open(QIODevice::OpenMode openMode) ensureStorage(); - QTC_ASSERT(m_tempStorage->open(), return false); + const bool isOpened = m_tempStorage->open(); + QTC_ASSERT(isOpened, return false); bool read = openMode & QIODevice::ReadOnly; bool write = openMode & QIODevice::WriteOnly; @@ -76,7 +77,8 @@ bool FSEngineImpl::open(QIODevice::OpenMode openMode) bool FSEngineImpl::close() { - QTC_ASSERT(flush(), return false); + const bool isFlushed = flush(); + QTC_ASSERT(isFlushed, return false); if (m_tempStorage) m_tempStorage->close(); return true; diff --git a/src/libs/utils/processreaper.cpp b/src/libs/utils/processreaper.cpp index 2638b09b1ed..67edc792702 100644 --- a/src/libs/utils/processreaper.cpp +++ b/src/libs/utils/processreaper.cpp @@ -117,8 +117,9 @@ private: void handleFinished() { // In case the process is still running - wait until it has finished - QTC_ASSERT(emitFinished(), QTimer::singleShot(m_reaperSetup.m_timeoutMs, - this, &Reaper::handleFinished)); + const bool isFinished = emitFinished(); + QTC_ASSERT(isFinished, QTimer::singleShot(m_reaperSetup.m_timeoutMs, + this, &Reaper::handleFinished)); } void handleTerminateTimeout() @@ -187,7 +188,8 @@ private: Reaper *reaper = new Reaper(reaperSetup); connect(reaper, &Reaper::finished, this, [this, reaper, process = reaperSetup.m_process] { QMutexLocker locker(&m_mutex); - QTC_CHECK(m_reaperList.removeOne(reaper)); + const bool isRemoved = m_reaperList.removeOne(reaper); + QTC_CHECK(isRemoved); delete reaper; delete process; if (m_reaperList.isEmpty())