feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Streamline ramping down

Browse Source 
There were only two used target states, and in case of mixed
debugging all parts of the machinery better agree on the
direction. So one bool in the (shared) runTool is sufficient.

Change-Id: Iffbf1651b82dde707cfc37d8da9d3da573b34b76
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2017-05-19 11:54:13 +02:00
parent 5e84af54a0
commit 36ec37b29d
10 changed files with 44 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/debugger/debuggerplugin.cpp
View File

@@ -930,11 +930,10 @@ public:
currentEngine()->watchHandler()->watchVariable(exp);
}
void handleExecExit()
void stopDebugger()
{
QTC_ASSERT(dd->m_currentRunTool, return);
return dd->m_currentRunTool->runControl()->initiateStop();
//currentEngine()->exitDebugger();
dd->m_currentRunTool->runControl()->initiateStop();
}
void handleFrameDown()
@@ -1416,7 +1415,7 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments,
act = m_exitAction = new QAction(tr("Stop Debugger"), this);
act->setIcon(Icons::DEBUG_EXIT_SMALL.icon());
connect(act, &QAction::triggered, this, &DebuggerPluginPrivate::handleExecExit);
connect(act, &QAction::triggered, this, &DebuggerPluginPrivate::stopDebugger);
act = m_interruptAction = new QAction(tr("Interrupt"), this);
act->setIcon(visibleStartIcon(Id(Constants::INTERRUPT), false));
@@ -2828,10 +2827,8 @@ void DebuggerPluginPrivate::coreShutdown()
{
m_shuttingDown = true;
if (currentEngine()) {
if (currentEngine()->state() != Debugger::DebuggerNotReady) {
currentEngine()->setTargetState(Debugger::DebuggerFinished);
if (currentEngine()->state() != Debugger::DebuggerNotReady)
currentEngine()->abortDebugger();
}
}
}
@@ -3044,8 +3041,9 @@ void DebuggerPluginPrivate::extensionsInitialized()
DebuggerEngine *currentEngine()
{
QTC_ASSERT(dd->m_currentRunTool, return dd->dummyEngine());
DebuggerEngine *engine = dd->m_currentRunTool->activeEngine();
DebuggerEngine *engine = nullptr;
if (dd->m_currentRunTool)
engine = dd->m_currentRunTool->activeEngine();
return engine ? engine : dd->dummyEngine();
}
@@ -3369,7 +3367,8 @@ void DebuggerPluginPrivate::updateUiForTarget(Target *target)
void DebuggerPluginPrivate::updateActiveLanguages()
{
QTC_ASSERT(dd->m_currentRunTool, return);
if (!dd->m_currentRunTool)
return;
const DebuggerLanguages languages = dd->m_currentRunTool->runParameters().languages;
// Id perspective = (languages & QmlLanguage) && !(languages & CppLanguage)
// ? QmlPerspectiveId : CppPerspectiveId;