feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ExtensionSystem: Fix some clazy warnings

Browse Source 
Fix use multi-arg.
Add a context object to lambda connections.

Change-Id: I02711c9ecc55188fb174895f7df59f25effd0834
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2022-12-07 01:01:14 +01:00
parent 0b9711b9c5
commit 36ffacabe7
3 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/libs/extensionsystem/pluginview.cpp
View File

@@ -303,10 +303,10 @@ PluginView::PluginView(QWidget *parent)
connect(PluginManager::instance(), &PluginManager::pluginsChanged,
this, &PluginView::updatePlugins);
connect(m_categoryView, &QAbstractItemView::activated,
connect(m_categoryView, &QAbstractItemView::activated, this,
[this](const QModelIndex &idx) { emit pluginActivated(pluginForIndex(idx)); });
connect(m_categoryView->selectionModel(), &QItemSelectionModel::currentChanged,
connect(m_categoryView->selectionModel(), &QItemSelectionModel::currentChanged, this,
[this](const QModelIndex &idx) { emit currentPluginChanged(pluginForIndex(idx)); });
updatePlugins();
@@ -385,12 +385,12 @@ bool PluginView::setPluginsEnabled(const QSet<PluginSpec *> &plugins, bool enabl
additionalPlugins.subtract(plugins);
if (!additionalPlugins.isEmpty()) {
if (QMessageBox::question(this, tr("Enabling Plugins"),
tr("Enabling\n%1\nwill also enable the following plugins:\n\n%2")
.arg(pluginListString(plugins))
.arg(pluginListString(additionalPlugins)),
QMessageBox::Ok | QMessageBox::Cancel,
QMessageBox::Ok) != QMessageBox::Ok)
tr("Enabling\n%1\nwill also enable the following plugins:\n\n%2")
.arg(pluginListString(plugins), pluginListString(additionalPlugins)),
QMessageBox::Ok | QMessageBox::Cancel,
QMessageBox::Ok) != QMessageBox::Ok) {
return false;
}
}
} else {
for (PluginSpec *spec : plugins) {
@@ -402,12 +402,12 @@ bool PluginView::setPluginsEnabled(const QSet<PluginSpec *> &plugins, bool enabl
additionalPlugins.subtract(plugins);
if (!additionalPlugins.isEmpty()) {
if (QMessageBox::question(this, tr("Disabling Plugins"),
tr("Disabling\n%1\nwill also disable the following plugins:\n\n%2")
.arg(pluginListString(plugins))
.arg(pluginListString(additionalPlugins)),
QMessageBox::Ok | QMessageBox::Cancel,
QMessageBox::Ok) != QMessageBox::Ok)
tr("Disabling\n%1\nwill also disable the following plugins:\n\n%2")
.arg(pluginListString(plugins), pluginListString(additionalPlugins)),
QMessageBox::Ok | QMessageBox::Cancel,
QMessageBox::Ok) != QMessageBox::Ok) {
return false;
}
}
}