From 370410aca06e75139414ae1f5cd34efa541e5c1b Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Wed, 9 Jun 2021 13:45:58 +0200 Subject: [PATCH] CMake: use a robuster way to check for WebEngineWidgets By using find_package(Qt5 COMPONENTS WebEngineWidgets) we make sure that the WebEngineWidgetsConfig.cmake from the same Qt5 package would be marked as found. Otherwise CMake would look around after a Qt5WebEngineWidgets package, which on Windows if you have a MSVC Qt Creator trying to build a MinGW Qt Creator could end up in a failed build. Change-Id: Ibd30c36231577ef111d9163cc1c87a09443d3cb9 Reviewed-by: Eike Ziller --- src/plugins/help/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/help/CMakeLists.txt b/src/plugins/help/CMakeLists.txt index 112402757b9..1e6c606d8b7 100644 --- a/src/plugins/help/CMakeLists.txt +++ b/src/plugins/help/CMakeLists.txt @@ -49,7 +49,7 @@ extend_qtc_plugin(Help macwebkithelpviewer.mm ) -find_package(Qt5WebEngineWidgets QUIET) +find_package(Qt5 COMPONENTS WebEngineWidgets QUIET) extend_qtc_plugin(Help CONDITION TARGET Qt5::WebEngineWidgets FEATURE_INFO "QtWebEngine help viewer"