feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Remove QmlProfilerRunner::serverUrl()

Browse Source 
There's more direct access using  runControl()->qmlChannel() nowadays.

Change-Id: Ie2797800d6ad8949faae0140db343f0bfc8eaf76
Reviewed-by: Andrii Semkiv <andrii.semkiv@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
hjk
2024-10-23 12:05:50 +02:00
parent 125d443606
commit 3757d910cc
3 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/qmlprofiler/qmlprofilerruncontrol.cpp
View File

@@ -163,11 +163,6 @@ void QmlProfilerRunner::profilerStateChanged()
} }
} }
QUrl QmlProfilerRunner::serverUrl() const
{
return runControl()->qmlChannel();
}
// //
// LocalQmlProfilerSupport // LocalQmlProfilerSupport
// //
@@ -206,9 +201,9 @@ LocalQmlProfilerSupport::LocalQmlProfilerSupport(RunControl *runControl, const Q
// In the TCP case, it doesn't hurt either to start the profiler before. // In the TCP case, it doesn't hurt either to start the profiler before.
addStartDependency(profiler); addStartDependency(profiler);
setStartModifier([this, profiler, serverUrl] { setStartModifier([this, runControl, serverUrl] {
QUrl serverUrl = profiler->serverUrl(); QUrl serverUrl = runControl->qmlChannel();
QString code; QString code;
if (serverUrl.scheme() == Utils::urlSocketScheme()) if (serverUrl.scheme() == Utils::urlSocketScheme())
code = QString("file:%1").arg(serverUrl.path()); code = QString("file:%1").arg(serverUrl.path());

2
src/plugins/qmlprofiler/qmlprofilerruncontrol.h
View File

@@ -24,8 +24,6 @@ public:
QmlProfilerRunner(ProjectExplorer::RunControl *runControl); QmlProfilerRunner(ProjectExplorer::RunControl *runControl);
~QmlProfilerRunner() override; ~QmlProfilerRunner() override;
QUrl serverUrl() const;
void registerProfilerStateManager( QmlProfilerStateManager *profilerState ); void registerProfilerStateManager( QmlProfilerStateManager *profilerState );
void cancelProcess(); void cancelProcess();

2
src/plugins/qmlprofiler/qmlprofilertool.cpp
View File

@@ -429,7 +429,7 @@ void QmlProfilerTool::finalizeRunControl(QmlProfilerRunner *runWorker)
infoBox->show(); infoBox->show();
}, Qt::QueuedConnection); // Queue any connection failures after reportStarted() }, Qt::QueuedConnection); // Queue any connection failures after reportStarted()
d->m_profilerConnections->connectToServer(runWorker->serverUrl()); d->m_profilerConnections->connectToServer(runControl->qmlChannel());
d->m_profilerState->setCurrentState(QmlProfilerStateManager::AppRunning); d->m_profilerState->setCurrentState(QmlProfilerStateManager::AppRunning);
} }