feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Rework aspect implementation

Browse Source 
This avoids some repetition and could be a step towards
having type storage in (or rather accessible from) the base,
so we can have aspects for more complex data (treemodels...)
that are not easily converted to QVariant.

Change-Id: I9797b3d5646195705212db1830d2b415291ac651
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-06-26 11:02:42 +02:00
parent 900ea82fd1
commit 379e7f906e
30 changed files with 463 additions and 643 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/copilot/copilotoptionspage.cpp
View File

@@ -79,10 +79,8 @@ public:
auto updateAuthWidget = [authWidget]() {
authWidget->updateClient(
FilePath::fromUserInput(
CopilotSettings::instance().nodeJsPath.volatileValue().toString()),
FilePath::fromUserInput(
CopilotSettings::instance().distPath.volatileValue().toString()));
FilePath::fromUserInput(CopilotSettings::instance().nodeJsPath.volatileValue()),
FilePath::fromUserInput(CopilotSettings::instance().distPath.volatileValue()));
};
connect(CopilotSettings::instance().nodeJsPath.pathChooser(),

6
src/plugins/copilot/copilotplugin.cpp
View File

@@ -142,10 +142,8 @@ void CopilotPlugin::initialize()
requestAction->setEnabled(enabled);
};
connect(&CopilotSettings::instance().enableCopilot,
&BoolAspect::valueChanged,
this,
updateActions);
connect(&CopilotSettings::instance().enableCopilot, &BaseAspect::changed,
this, updateActions);
updateActions();

4
src/plugins/copilot/copilotsettings.cpp
View File

@@ -92,8 +92,8 @@ CopilotProjectSettings::CopilotProjectSettings(ProjectExplorer::Project *project
QVariantMap map = project->namedSettings(Constants::COPILOT_PROJECT_SETTINGS_ID).toMap();
fromMap(map);
connect(&enableCopilot, &BoolAspect::valueChanged, this, [this, project] { save(project); });
connect(&useGlobalSettings, &BoolAspect::valueChanged, this, [this, project] { save(project); });
connect(&enableCopilot, &BaseAspect::changed, this, [this, project] { save(project); });
connect(&useGlobalSettings, &BaseAspect::changed, this, [this, project] { save(project); });
}
void CopilotProjectSettings::setUseGlobalSettings(bool useGlobal)