feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TaskTree: Get rid of onGroupError element

Browse Source 
Make it possible to setup onGroupDone element with additional
OnDone argument.
The onGroupDone handler may accept extra DoneResult argument.
The onGroupDone handler may also tweak the success bit of a group.

All above features conform to the behavior of the task done handler.

Task-number: QTCREATORBUG-29834
Change-Id: I125bdfe155e585678fb33410632246401cbc9390
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2023-11-03 18:50:32 +01:00
parent fbe359308d
commit 37b6cb7f90
27 changed files with 253 additions and 275 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/diffeditor/diffeditorplugin.cpp
View File

@@ -132,24 +132,21 @@ DiffFilesController::DiffFilesController(IDocument *document)
}
taskTree.setRecipe(tasks);
};
const auto onTreeDone = [this, storage] {
const QList<std::optional<FileData>> &results = *storage;
const auto onTreeDone = [this, storage](DoneWith result) {
QList<FileData> finalList;
for (const std::optional<FileData> &result : results) {
if (result.has_value())
finalList.append(*result);
if (result == DoneWith::Success) {
const QList<std::optional<FileData>> &results = *storage;
for (const std::optional<FileData> &result : results) {
if (result.has_value())
finalList.append(*result);
}
}
setDiffFiles(finalList);
};
const auto onTreeError = [this, storage] {
setDiffFiles({});
};
const Group root = {
Storage(storage),
TaskTreeTask(onTreeSetup),
onGroupDone(onTreeDone),
onGroupError(onTreeError)
TaskTreeTask(onTreeSetup, onTreeDone)
};
setReloadRecipe(root);
}