feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Simplify AndroidBuildApkStep::findInBuild

Browse Source 
AndroidBuildApkStep are only ever inserted into the build step list,
never the clean step list.

Change-Id: I9a56bd045bf2434ac50649f3ce68209942c1ddba
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
This commit is contained in:
hjk
2019-01-22 17:43:24 +01:00
parent 4ee5d68b33
commit 37c009e195
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/android/androidbuildapkstep.cpp
View File

@@ -138,11 +138,9 @@ AndroidBuildApkStep *AndroidBuildApkStep::findInBuild(const BuildConfiguration *
{ {
if (!bc) if (!bc)
return nullptr; return nullptr;
for (const Core::Id &id : bc->knownStepLists()) { BuildStepList *bsl = bc->stepList(ProjectExplorer::Constants::BUILDSTEPS_BUILD);
if (auto step = bc->stepList(id)->firstOfType<AndroidBuildApkStep>()) QTC_ASSERT(bsl, return nullptr);
return step; return bsl->firstOfType<AndroidBuildApkStep>();
}
return nullptr;
} }
bool AndroidBuildApkStep::init() bool AndroidBuildApkStep::init()