feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

HelpViewers: Fix context menu item title and corresponding symbol names

Browse Source 
It should be "Open Link as New Page", not "New Window".

Change-Id: Iccfd179370e912028f8d0d2562cfe51e6f7d6ccd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
This commit is contained in:
Eike Ziller
2014-09-23 17:10:26 +02:00
parent b6098da75b
commit 37e06c8d53
8 changed files with 43 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/help/textbrowserhelpviewer.cpp
View File

@@ -177,9 +177,9 @@ void TextBrowserHelpViewer::addForwardHistoryItems(QMenu *forwardMenu)
}
}
void TextBrowserHelpViewer::setOpenInNewWindowActionVisible(bool visible)
void TextBrowserHelpViewer::setOpenInNewPageActionVisible(bool visible)
{
m_textBrowser->showOpenInNewWindowAction = visible;
m_textBrowser->m_openInNewPageActionVisible = visible;
}
bool TextBrowserHelpViewer::findText(const QString &text, Core::FindFlags flags,
@@ -287,7 +287,7 @@ TextBrowserHelpWidget::TextBrowserHelpWidget(int zoom, TextBrowserHelpViewer *pa
, zoomCount(zoom)
, forceFont(false)
, lastAnchor(QString())
, showOpenInNewWindowAction(true)
, m_openInNewPageActionVisible(true)
, m_parent(parent)
{
installEventFilter(this);
@@ -368,8 +368,9 @@ void TextBrowserHelpWidget::contextMenuEvent(QContextMenuEvent *event)
if (link.isRelative())
link = source().resolved(link);
menu.addAction(tr("Open Link"), this, SLOT(openLink()));
if (showOpenInNewWindowAction)
menu.addAction(tr("Open Link as New Page"), this, SLOT(openLinkInNewPage()));
if (m_openInNewPageActionVisible)
menu.addAction(QCoreApplication::translate("HelpViewer", "Open Link as New Page"),
this, SLOT(openLinkInNewPage()));
if (!link.isEmpty() && link.isValid())
copyAnchorAction = menu.addAction(tr("Copy Link"));