From 381ff44f6678085917357898ec58cb3fe0d39e58 Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Fri, 7 Jul 2023 12:05:25 +0200 Subject: [PATCH] Debugger: Fix post mortem action on Windows Change-Id: I411853098f3bb7c410b4446bb6f2ed61fb11b217 Reviewed-by: Reviewed-by: hjk --- src/plugins/debugger/commonoptionspage.cpp | 5 ----- src/plugins/debugger/debuggeractions.cpp | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/plugins/debugger/commonoptionspage.cpp b/src/plugins/debugger/commonoptionspage.cpp index 8d0dda445f5..0369ed14893 100644 --- a/src/plugins/debugger/commonoptionspage.cpp +++ b/src/plugins/debugger/commonoptionspage.cpp @@ -29,11 +29,6 @@ public: DebuggerSettings &s = settings(); setOnApply([&s] { - const bool originalPostMortem = s.registerForPostMortem->value(); - const bool currentPostMortem = s.registerForPostMortem->volatileValue(); - // explicitly trigger setValue() to override the setValueSilently() and trigger the registration - if (originalPostMortem != currentPostMortem) - s.registerForPostMortem->setValue(currentPostMortem); s.page1.apply(); s.page1.writeSettings(); }); diff --git a/src/plugins/debugger/debuggeractions.cpp b/src/plugins/debugger/debuggeractions.cpp index bf1b8f76f30..e4026bca81d 100644 --- a/src/plugins/debugger/debuggeractions.cpp +++ b/src/plugins/debugger/debuggeractions.cpp @@ -405,6 +405,8 @@ DebuggerSettings::DebuggerSettings() page1.registerAspect(&forceLoggingToConsole); page1.registerAspect(&sourcePathMap); + if (HostOsInfo::isWindowsHost()) + page1.registerAspect(registerForPostMortem); // Page 4 page4.registerAspect(&useDebuggingHelpers); @@ -429,8 +431,6 @@ DebuggerSettings::DebuggerSettings() page5.registerAspect(&firstChanceExceptionTaskEntry); page5.registerAspect(&secondChanceExceptionTaskEntry); page5.registerAspect(&ignoreFirstChanceAccessViolation); - if (HostOsInfo::isWindowsHost()) - page5.registerAspect(registerForPostMortem); // Page 6 page6.registerAspect(&cdbSymbolPaths);