feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Refactor CommandMappings to be a widget instead of options page

Browse Source 
The IOptionsPage parts in it were trivial, and we need more flexibility
for the shortcut settings options pages.

Change-Id: I93ddaf060ac88ef339da9f542719f2d695660ac0
Reviewed-by: hjk <hjk@theqtcompany.com>
This commit is contained in:
Eike Ziller
2015-04-27 12:29:55 +02:00
parent 2b66e48bcf
commit 384437e994
5 changed files with 210 additions and 182 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/plugins/coreplugin/actionmanager/commandmappings.h
View File

@@ -31,7 +31,9 @@
#ifndef COMMANDMAPPINGS_H
#define COMMANDMAPPINGS_H
#include <coreplugin/dialogs/ioptionspage.h>
#include <coreplugin/core_global.h>
#include <QWidget>
QT_BEGIN_NAMESPACE
class QLineEdit;
@@ -45,31 +47,32 @@ namespace Core {
namespace Internal { class CommandMappingsPrivate; }
class CORE_EXPORT CommandMappings : public IOptionsPage
class CORE_EXPORT CommandMappings : public QWidget
{
Q_OBJECT
public:
CommandMappings(QObject *parent = 0);
CommandMappings(QWidget *parent = 0);
~CommandMappings();
virtual bool hasConflicts() const;
protected slots:
void commandChanged(QTreeWidgetItem *current);
void filterChanged(const QString &f);
virtual void importAction() {}
virtual void exportAction() {}
virtual void defaultAction() = 0;
protected:
// IOptionsPage
QWidget *widget();
virtual void apply() {}
virtual void finish();
virtual void removeTargetIdentifier() = 0;
virtual void resetTargetIdentifier() = 0;
virtual void targetIdentifierChanged() = 0;
virtual void initialize() = 0;
virtual void defaultAction() = 0;
virtual void exportAction() {}
virtual void importAction() {}
void filterChanged(const QString &f);
bool filter(const QString &filterString, QTreeWidgetItem *item);
virtual void commandChanged(QTreeWidgetItem *current);
// access to m_page
void setImportExportEnabled(bool enabled);
QTreeWidget *commandList() const;