feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Fix the crash in function overload completion

Browse Source 
Check that the completions container is not empty.

Change-Id: I399b8cce42995d758013441d2d3d9f3d8156dc06
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Ivan Donchevskii
2018-10-05 14:43:30 +02:00
parent 66e5d2f492
commit 3858c7d3b9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/clangcodemodel/clangcompletionassistprocessor.cpp
View File

@@ -185,7 +185,7 @@ void ClangCompletionAssistProcessor::handleAvailableCompletions(const CodeComple
{ {
QTC_CHECK(m_completions.isEmpty()); QTC_CHECK(m_completions.isEmpty());
if (m_sentRequestType == FunctionHintCompletion) { if (m_sentRequestType == FunctionHintCompletion && !completions.isEmpty()) {
const CodeCompletion &firstCompletion = completions.front(); const CodeCompletion &firstCompletion = completions.front();
if (firstCompletion.completionKind == CodeCompletion::FunctionOverloadCompletionKind) { if (firstCompletion.completionKind == CodeCompletion::FunctionOverloadCompletionKind) {
setAsyncProposalAvailable(createFunctionHintProposal(completions)); setAsyncProposalAvailable(createFunctionHintProposal(completions));