From 3859b2d8f20540c1dcaf7c2af8839de4ed2f8a89 Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 26 Jul 2024 11:42:43 +0200 Subject: [PATCH] Core: Save mime settings changes directly on apply The only time it actually changes. Change-Id: I78e6e9d61a3dfbd19bd4b422d6696df75dfd50a4 Reviewed-by: Eike Ziller --- src/plugins/coreplugin/mimetypesettings.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/plugins/coreplugin/mimetypesettings.cpp b/src/plugins/coreplugin/mimetypesettings.cpp index 281a45ceb87..50ca8f95253 100644 --- a/src/plugins/coreplugin/mimetypesettings.cpp +++ b/src/plugins/coreplugin/mimetypesettings.cpp @@ -252,7 +252,7 @@ bool MimeFilterModel::filterAcceptsRow(int source_row, const QModelIndex &source const QChar kSemiColon(QLatin1Char(';')); -class MimeTypeSettingsPage final : public QObject, public IOptionsPage +class MimeTypeSettingsPage final : public IOptionsPage { public: MimeTypeSettingsPage(); @@ -283,6 +283,7 @@ public: Core::Internal::setUserPreferredEditorTypes(d->m_model.m_userDefault); d->m_pendingModifiedMimeTypes.clear(); d->m_model.load(); + d->writeUserModifiedMimeTypes(); } void finish() final @@ -748,8 +749,6 @@ MimeTypeSettingsPage::MimeTypeSettingsPage() m_filterModel.setSourceModel(&m_model); m_filterModel.setFilterKeyColumn(-1); m_filterModel.setFilterCaseSensitivity(Qt::CaseInsensitive); - connect(ICore::instance(), &ICore::saveSettingsRequested, - this, &MimeTypeSettingsPage::writeUserModifiedMimeTypes); m_userModifiedMimeTypes = readUserModifiedMimeTypes(); Utils::addMimeInitializer([this] { registerUserModifiedMimeTypes(m_userModifiedMimeTypes); });