feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ScreenRecorder: Make dialog less cluttered and non-resizable

Browse Source 
The "Trim and Crop..." button now jas a static text and shows crop and
trim details via tooltip.

The confusing resizability of the dialog is prevented.

Change-Id: If967d8014a0751f7d2360bf7b239bf22f070024c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Alessandro Portale
2023-09-07 22:35:13 +02:00
parent 0701145c55
commit 38690bc7d0
3 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/screenrecorder/cropandtrim.cpp
View File

@@ -688,6 +688,7 @@ CropAndTrimWidget::CropAndTrimWidget(QWidget *parent)
: StyledBar(parent) : StyledBar(parent)
{ {
m_button = new QToolButton; m_button = new QToolButton;
m_button->setText(Tr::tr("Crop and Trim..."));
m_cropSizeWarningIcon = new CropSizeWarningIcon(CropSizeWarningIcon::ToolBarVariant); m_cropSizeWarningIcon = new CropSizeWarningIcon(CropSizeWarningIcon::ToolBarVariant);
@@ -727,17 +728,20 @@ void CropAndTrimWidget::setClip(const ClipInfo &clip)
void CropAndTrimWidget::updateWidgets() void CropAndTrimWidget::updateWidgets()
{ {
const QString cropText = if (!m_clipInfo.isNull()) {
!m_clipInfo.isCompleteArea(m_cropRect) const QString cropText =
? Tr::tr("Crop to %1x%2px.").arg(m_cropRect.width()).arg(m_cropRect.height()) !m_clipInfo.isCompleteArea(m_cropRect)
: Tr::tr("Complete area."); ? Tr::tr("Crop to %1x%2px.").arg(m_cropRect.width()).arg(m_cropRect.height())
: Tr::tr("Complete area.");
const QString trimText = const QString trimText =
!m_clipInfo.isCompleteRange(m_trimRange) !m_clipInfo.isCompleteRange(m_trimRange)
? Tr::tr("Frames %1 to %2.").arg(m_trimRange.first).arg(m_trimRange.second) ? Tr::tr("Frames %1 to %2.").arg(m_trimRange.first).arg(m_trimRange.second)
: Tr::tr("Complete clip."); : Tr::tr("Complete clip.");
m_button->setToolTip(cropText + " " + trimText);
}
m_button->setText(cropText + " " + trimText + "..");
m_cropSizeWarningIcon->setCropSize(m_cropRect.size()); m_cropSizeWarningIcon->setCropSize(m_cropRect.size());
} }

2
src/plugins/screenrecorder/record.cpp
View File

@@ -174,6 +174,8 @@ RecordWidget::RecordWidget(const FilePath &recordFile, QWidget *parent)
: StyledBar(parent) : StyledBar(parent)
, m_recordFile(recordFile) , m_recordFile(recordFile)
{ {
setMinimumWidth(220);
m_process = new Process(this); m_process = new Process(this);
m_process->setUseCtrlCStub(true); m_process->setUseCtrlCStub(true);
m_process->setProcessMode(ProcessMode::Writer); m_process->setProcessMode(ProcessMode::Writer);

3
src/plugins/screenrecorder/screenrecorderplugin.cpp
View File

@@ -44,7 +44,6 @@ public:
, m_recordFile("XXXXXX" + RecordWidget::recordFileExtension()) , m_recordFile("XXXXXX" + RecordWidget::recordFileExtension())
{ {
setWindowTitle(Tr::tr("Record Screen")); setWindowTitle(Tr::tr("Record Screen"));
setMinimumWidth(320);
StyleHelper::setPanelWidget(this); StyleHelper::setPanelWidget(this);
m_recordFile.open(); m_recordFile.open();
@@ -89,6 +88,8 @@ public:
m_spinner = new SpinnerSolution::Spinner(SpinnerSolution::SpinnerSize::Medium, this); m_spinner = new SpinnerSolution::Spinner(SpinnerSolution::SpinnerSize::Medium, this);
m_spinner->hide(); m_spinner->hide();
layout()->setSizeConstraint(QLayout::SetFixedSize);
} }
private: private: