feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Introduce a BaseAspect::setEnabler(BoolAspect *)

Browse Source 
A convenience method to tie the enabled state of an aspect to some
other bool aspect, to be used e.g. when settings item availability
depends on some check box.

Makes it harder to miss one of the three necessary steps.

Change-Id: I8c120bb6846aea2a503614f7c73fa57a149cab41
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2021-04-12 13:43:24 +02:00
parent ef108d7a06
commit 38b4536090
6 changed files with 22 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/autotest/boost/boosttestsettings.cpp
View File

@@ -74,6 +74,7 @@ BoostTestSettings::BoostTestSettings()
seed.setLabelText(tr("Seed:"));
seed.setToolTip(tr("A seed of 0 means no randomization. A value of 1 uses the current "
"time, any other value is used as random seed generator."));
seed.setEnabler(&randomize);
registerAspect(&randomize);
randomize.setSettingsKey("Randomize");
@@ -99,8 +100,6 @@ BoostTestSettings::BoostTestSettings()
memLeaks.setDefaultValue(true);
memLeaks.setLabelText(tr("Detect memory leaks"));
memLeaks.setToolTip(tr("Enable memory leak detection."));
QObject::connect(&randomize, &BoolAspect::volatileValueChanged, &seed, &BaseAspect::setEnabled);
}
BoostTestSettingsPage::BoostTestSettingsPage(BoostTestSettings *settings, Utils::Id settingsId)

21
src/plugins/autotest/catch/catchtestsettings.cpp
View File

@@ -44,33 +44,33 @@ CatchTestSettings::CatchTestSettings()
registerAspect(&abortAfter);
abortAfter.setSettingsKey("AbortAfter");
abortAfter.setRange(1, 9999);
abortAfter.setEnabled(false);
abortAfter.setEnabler(&abortAfterChecked);
registerAspect(&benchmarkSamples);
benchmarkSamples.setSettingsKey("BenchSamples");
benchmarkSamples.setRange(1, 999999);
benchmarkSamples.setDefaultValue(100);
benchmarkSamples.setEnabled(false);
benchmarkSamples.setEnabler(&samplesChecked);
registerAspect(&benchmarkResamples);
benchmarkResamples.setSettingsKey("BenchResamples");
benchmarkResamples.setRange(1, 9999999);
benchmarkResamples.setDefaultValue(100000);
benchmarkResamples.setToolTip(tr("Number of resamples for bootstrapping."));
benchmarkResamples.setEnabled(false);
benchmarkResamples.setEnabler(&resamplesChecked);
registerAspect(&confidenceInterval);
confidenceInterval.setSettingsKey("BenchConfInt");
confidenceInterval.setRange(0., 1.);
confidenceInterval.setSingleStep(0.05);
confidenceInterval.setDefaultValue(0.95);
confidenceInterval.setEnabled(false);
confidenceInterval.setEnabler(&confidenceIntervalChecked);
registerAspect(&benchmarkWarmupTime);
benchmarkWarmupTime.setSettingsKey("BenchWarmup");
benchmarkWarmupTime.setSuffix(tr(" ms"));
benchmarkWarmupTime.setRange(0, 10000);
benchmarkWarmupTime.setEnabled(false);
benchmarkWarmupTime.setEnabler(&warmupChecked);
registerAspect(&abortAfterChecked);
abortAfterChecked.setSettingsKey("AbortChecked");
@@ -133,17 +133,6 @@ CatchTestSettings::CatchTestSettings()
if (auto boolAspect = dynamic_cast<BoolAspect *>(aspect))
boolAspect->setLabelPlacement(BoolAspect::LabelPlacement::AtCheckBoxWithoutDummyLabel);
});
QObject::connect(&abortAfterChecked, &BoolAspect::volatileValueChanged,
&abortAfter, &BaseAspect::setEnabled);
QObject::connect(&samplesChecked, &BoolAspect::volatileValueChanged,
&benchmarkSamples, &BaseAspect::setEnabled);
QObject::connect(&resamplesChecked, &BoolAspect::volatileValueChanged,
&benchmarkResamples, &BaseAspect::setEnabled);
QObject::connect(&confidenceIntervalChecked, &BoolAspect::volatileValueChanged,
&confidenceInterval, &BaseAspect::setEnabled);
QObject::connect(&warmupChecked, &BoolAspect::volatileValueChanged,
&benchmarkWarmupTime, &BaseAspect::setEnabled);
}
CatchTestSettingsPage::CatchTestSettingsPage(CatchTestSettings *settings, Utils::Id settingsId)