Fix various compiler warnings

Change-Id: I59db57e8501bbd0d0293ccce1b520df8acc07413
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/android/androiddevice.cpp

@@ -151,7 +151,7 @@ AndroidDevice::AndroidDevice()
     setOsType(Utils::OsTypeOtherUnix);
     setDeviceState(DeviceConnected);
 
-    addDeviceAction({tr("Refresh"), [](const IDevice::Ptr &device, QWidget *parent) {
+    addDeviceAction({tr("Refresh"), [](const IDevice::Ptr &, QWidget *) {
         AndroidDeviceManager::instance()->updateDevicesListOnce();
     }});
 
@@ -614,8 +614,8 @@ AndroidDeviceManager *AndroidDeviceManager::instance()
 
 AndroidDeviceManager::AndroidDeviceManager(QObject *parent)
     : QObject(parent),
-      m_androidConfig(AndroidConfigurations::currentConfig()),
-      m_avdManager(m_androidConfig)
+      m_avdManager(m_androidConfig),
+      m_androidConfig(AndroidConfigurations::currentConfig())
 {
     connect(qApp, &QCoreApplication::aboutToQuit, this, [this]() {
         m_devicesUpdaterTimer.stop();

src/plugins/android/androidsdkmanagerwidget.cpp

@@ -133,7 +133,6 @@ AndroidSdkManagerWidget::AndroidSdkManagerWidget(AndroidConfig &config,
 
     m_ui->searchField->setPlaceholderText("Filter");
     connect(m_ui->searchField, &QLineEdit::textChanged, [this, proxyModel](const QString &text) {
-        const bool isExpanded = m_ui->expandCheck->isChecked();
         proxyModel->setAcceptedSearchPackage(text);
         m_sdkModel->resetSelection();
         // It is more convenient to expand the view with the results
@@ -513,7 +512,7 @@ bool PackageFilterModel::filterAcceptsRow(int sourceRow, const QModelIndex &sour
         }
     }
 
-    return showTopLevel || (packageState(srcIndex) & m_packageState) && packageFound(srcIndex);
+    return showTopLevel || ((packageState(srcIndex) & m_packageState) && packageFound(srcIndex));
 }
 
 OptionsDialog::OptionsDialog(AndroidSdkManager *sdkManager, const QStringList &args,

src/plugins/clangformat/clangformatfile.cpp

@@ -105,7 +105,7 @@ void ClangFormatFile::saveNewFormat()
 
     // workaround: configurationAsText() add comment "# " before BasedOnStyle line
     const int pos = style.find("# BasedOnStyle");
-    if (pos < style.size())
+    if (pos < int(style.size()))
         style.erase(pos, 2);
     m_filePath.writeFileContents(QByteArray::fromStdString(style));
 }

src/plugins/qmldesigner/components/formeditor/formeditorview.cpp

@@ -344,6 +344,7 @@ void FormEditorView::nodeReparented(const ModelNode &node, const NodeAbstractPro
 
 void FormEditorView::nodeSourceChanged(const ModelNode &node, const QString &newNodeSource)
 {
+    Q_UNUSED(newNodeSource)
     addOrRemoveFormEditorItem(node);
 }
 

src/plugins/qmldesigner/designercore/metainfo/metainforeader.cpp

@@ -89,6 +89,7 @@ void MetaInfoReader::setQualifcation(const TypeName &qualification)
 
 void MetaInfoReader::elementStart(const QString &name, const QmlJS::SourceLocation &nameLocation)
 {
+    Q_UNUSED(nameLocation)
     switch (parserState()) {
     case ParsingDocument: setParserState(readDocument(name)); break;
     case ParsingMetaInfo: setParserState(readMetaInfoRootElement(name)); break;
@@ -133,6 +134,8 @@ void MetaInfoReader::propertyDefinition(const QString &name,
                         const QVariant &value,
                         const QmlJS::SourceLocation &valueLocation)
 {
+    Q_UNUSED(nameLocation)
+    Q_UNUSED(valueLocation)
     switch (parserState()) {
     case ParsingType: readTypeProperty(name, value); break;
     case ParsingImports: readImportsProperty(name, value); break;

src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp

@@ -332,7 +332,7 @@ static void removeStateOperationsForChildren(const QmlObjectNode &node)
             stateOperation.modelNode().destroy(); //remove of belonging StatesOperations
         }
 
-        for (const QmlObjectNode &childNode : node.modelNode().directSubModelNodes()) {
+        for (const QmlObjectNode childNode : node.modelNode().directSubModelNodes()) {
             removeStateOperationsForChildren(childNode);
         }
     }

src/plugins/qmldesigner/designercore/model/qmltimelinekeyframegroup.cpp

@@ -310,7 +310,7 @@ QList<QmlTimelineKeyframeGroup> QmlTimelineKeyframeGroup::allInvalidTimelineKeyf
     QTC_ASSERT(view->rootModelNode().isValid(), return ret);
 
     const auto groups = view->rootModelNode().subModelNodesOfType("QtQuick.Timeline.KeyframeGroup");
-    for (const QmlTimelineKeyframeGroup &group : groups) {
+    for (const QmlTimelineKeyframeGroup group : groups) {
         if (group.isDangling())
             ret.append(group);
     }

src/plugins/qmldesigner/designercore/projectstorage/projectstoragetypes.h

@@ -650,9 +650,9 @@ public:
         , functionDeclarations{std::move(functionDeclarations)}
         , signalDeclarations{std::move(signalDeclarations)}
         , enumerationDeclarations{std::move(enumerationDeclarations)}
-        , moduleId{moduleId}
         , accessSemantics{accessSemantics}
         , sourceId{sourceId}
+        , moduleId{moduleId}
         , changeLevel{changeLevel}
     {}
 
@@ -663,9 +663,9 @@ public:
                   int sourceId)
         : typeName{typeName}
         , prototype{NativeType{prototype}}
-        , moduleId{moduleId}
         , accessSemantics{static_cast<TypeAccessSemantics>(accessSemantics)}
         , sourceId{sourceId}
+        , moduleId{moduleId}
 
     {}
 
@@ -677,10 +677,10 @@ public:
                   int sourceId)
         : typeName{typeName}
         , prototype{NativeType{prototype}}
-        , moduleId{moduleId}
         , accessSemantics{static_cast<TypeAccessSemantics>(accessSemantics)}
         , sourceId{sourceId}
         , typeId{typeId}
+        , moduleId{moduleId}
     {}
 
     friend bool operator==(const Type &first, const Type &second) noexcept