From 38ef30f4c2ac1e38af4c46d28d7d450e358da9f1 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Tue, 20 Jan 2015 12:16:13 +0100 Subject: [PATCH] VcsOutputWindow: Try harder to filter out password data Not perfect, but might catch some more passwords before they are echoed in cleartext. Change-Id: I61e537a4a3cbc69748e1f761a5a08fe03ff2552d Reviewed-by: Orgad Shaneh --- src/plugins/vcsbase/vcsoutputwindow.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/plugins/vcsbase/vcsoutputwindow.cpp b/src/plugins/vcsbase/vcsoutputwindow.cpp index 34548c9e56b..2ea251d3ed9 100644 --- a/src/plugins/vcsbase/vcsoutputwindow.cpp +++ b/src/plugins/vcsbase/vcsoutputwindow.cpp @@ -441,9 +441,13 @@ static inline QString formatArguments(const QStringList &args) const int size = args.size(); // Skip authentication options for (int i = 0; i < size; i++) { - const QString &arg = args.at(i); + const QString arg = filterPasswordFromUrls(args.at(i)); if (i) str << ' '; + if (arg.startsWith(QString::fromLatin1(passwordOptionC) + QLatin1Char('='))) { + str << "--password=********"; + continue; + } str << arg; if (arg == QLatin1String(passwordOptionC)) { str << " ********";