feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: rename "eventId" fields to "typeId" and "selectionId"

Browse Source 
The convention is now that selections are the rows in the expanded
timeline, "types" are the types in the QmlProfilerDataModel, and
events are the single boxes in the timeline. Thus, the event view
shows only types and for consistency the V8 view does so, too.

Having eventId as synonym for "type index" and "event index" as
actual index into the list of events is confusing.

Change-Id: I6b7c4c3f1ab0a8b71c511de52ab296a2e91cf5f0
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
This commit is contained in:
Ulf Hermann
2014-08-29 16:32:42 +02:00
parent 3af3878ace
commit 38f4d6a5f2
23 changed files with 160 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/qmlprofiler/timelinemodelaggregator.cpp
View File

@@ -220,9 +220,9 @@ qint64 TimelineModelAggregator::endTime(int modelIndex, int index) const
return d->modelList[modelIndex]->endTime(index);
}
int TimelineModelAggregator::eventId(int modelIndex, int index) const
int TimelineModelAggregator::selectionId(int modelIndex, int index) const
{
return d->modelList[modelIndex]->eventId(index);
return d->modelList[modelIndex]->selectionId(index);
}
int TimelineModelAggregator::bindingLoopDest(int modelIndex,int index) const
@@ -255,15 +255,15 @@ QVariantMap TimelineModelAggregator::location(int modelIndex, int index) const
return d->modelList[modelIndex]->location(index);
}
int TimelineModelAggregator::eventIdForTypeIndex(int modelIndex, int typeIndex) const
bool TimelineModelAggregator::isSelectionIdValid(int modelIndex, int typeIndex) const
{
return d->modelList[modelIndex]->eventIdForTypeIndex(typeIndex);
return d->modelList[modelIndex]->isSelectionIdValid(typeIndex);
}
int TimelineModelAggregator::eventIdForLocation(int modelIndex, const QString &filename,
int TimelineModelAggregator::selectionIdForLocation(int modelIndex, const QString &filename,
int line, int column) const
{
return d->modelList[modelIndex]->eventIdForLocation(filename, line, column);
return d->modelList[modelIndex]->selectionIdForLocation(filename, line, column);
}
void TimelineModelAggregator::swapModels(int modelIndex1, int modelIndex2)