ClangSupport: Clean up destructors

Clean up destructors in the class hierarchy based on IpcInterface.

Change-Id: Ia79784243858fff619a9df534384a7bca18f2bd0
Reviewed-by: Cristian Adam <cristian.adam@qt.io>

src/libs/clangsupport/clangcodemodelclientinterface.h

@@ -61,9 +61,6 @@ public:
     virtual void references(const ReferencesMessage &message) = 0;
     virtual void followSymbol(const FollowSymbolMessage &message) = 0;
     virtual void tooltip(const ToolTipMessage &message) = 0;
-
-protected:
-    ~ClangCodeModelClientInterface() = default;
 };
 
 } // namespace ClangBackEnd

src/libs/clangsupport/clangcodemodelserverinterface.h

@@ -36,7 +36,7 @@ class ClangCodeModelClientInterface;
 class CLANGSUPPORT_EXPORT ClangCodeModelServerInterface : public IpcServerInterface
 {
 public:
-    virtual ~ClangCodeModelServerInterface() = default;
+    ~ClangCodeModelServerInterface() override = default;
 
     void dispatch(const MessageEnvelop &messageEnvelop) override;
 

src/libs/clangsupport/ipcclientinterface.h

@@ -30,9 +30,6 @@
 namespace ClangBackEnd {
 
 class IpcClientInterface : public IpcInterface
-{
+{};
-protected:
-    ~IpcClientInterface() = default;
-};
 
 } // namespace ClangBackEnd

src/libs/clangsupport/ipcinterface.h

@@ -43,7 +43,7 @@ public:
     virtual void dispatch(const MessageEnvelop &messageEnvelop) = 0;
 
 protected:
-    ~IpcInterface() = default;
+    virtual ~IpcInterface() = default;
 };
 
 } // namespace ClangBackEnd

src/libs/clangsupport/ipcserverinterface.h

@@ -30,9 +30,6 @@
 namespace ClangBackEnd {
 
 class IpcServerInterface : public IpcInterface
-{
+{};
-protected:
-    ~IpcServerInterface() = default;
-};
 
 } // namespace ClangBackEnd

src/libs/clangsupport/pchmanagerclientinterface.h

@@ -40,9 +40,6 @@ public:
     virtual void alive() = 0;
     virtual void precompiledHeadersUpdated(PrecompiledHeadersUpdatedMessage &&message) = 0;
     virtual void progress(ProgressMessage &&message) = 0;
-
-protected:
-    ~PchManagerClientInterface() = default;
 };
 
 } // namespace ClangBackEnd

src/libs/clangsupport/pchmanagerserverinterface.h

@@ -39,9 +39,6 @@ public:
     void dispatch(const MessageEnvelop &messageEnvelop) override;
 
     virtual void end() = 0;
-
-protected:
-    ~PchManagerServerInterface() = default;
 };
 
 } // namespace ClangBackEnd

src/libs/clangsupport/projectmanagementserverinterface.h

@@ -41,9 +41,6 @@ public:
     virtual void removeProjectParts(RemoveProjectPartsMessage &&message) = 0;
     virtual void updateGeneratedFiles(UpdateGeneratedFilesMessage &&message) = 0;
     virtual void removeGeneratedFiles(RemoveGeneratedFilesMessage &&message) = 0;
-
-protected:
-    ~ProjectManagementServerInterface() = default;
 };
 
 } // namespace ClangBackEnd

src/libs/clangsupport/refactoringclientinterface.h

@@ -50,9 +50,6 @@ public:
     virtual void sourceRangesAndDiagnosticsForQueryMessage(SourceRangesAndDiagnosticsForQueryMessage &&message) = 0;
     virtual void sourceRangesForQueryMessage(SourceRangesForQueryMessage &&message) = 0;
     virtual void progress(ProgressMessage &&message) = 0;
-
-protected:
-    ~RefactoringClientInterface() = default;
 };
 
 } // namespace ClangBackEnd

src/libs/clangsupport/refactoringserverinterface.h

@@ -58,9 +58,6 @@ public:
         isAvailable_ = isAvailable;
     }
 
-protected:
-    ~RefactoringServerInterface() = default;
-
 private:
     bool isAvailable_ = false;
 };

src/plugins/clangcodemodel/clangbackendreceiver.h

@@ -46,7 +46,7 @@ class BackendReceiver : public ClangBackEnd::ClangCodeModelClientInterface
 {
 public:
     BackendReceiver();
-    ~BackendReceiver();
+    ~BackendReceiver() override;
 
     using AliveHandler = std::function<void ()>;
     void setAliveHandler(const AliveHandler &handler);