From 391dea86a714f91e4b6e112db92a76b353358f61 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Mon, 2 Dec 2013 11:15:38 +0100 Subject: [PATCH] DebuggerItem: Compare against original item from DebuggerItemManager Compare against the original item from the DebuggerItemManager, not to the item stored in the model. This will keep the change flag, even when switching back and forth between items in the model. Task-number: QTCREATORBUG-10954 Change-Id: I54535c45e3c3e45fabbf83e0a35c3bd674158892 Reviewed-by: hjk --- src/plugins/debugger/debuggeritemmodel.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/debugger/debuggeritemmodel.cpp b/src/plugins/debugger/debuggeritemmodel.cpp index 005115dbaea..913ebe5e1c7 100644 --- a/src/plugins/debugger/debuggeritemmodel.cpp +++ b/src/plugins/debugger/debuggeritemmodel.cpp @@ -152,8 +152,8 @@ bool DebuggerItemModel::updateDebuggerStandardItem(const DebuggerItem &item, boo QTC_ASSERT(parent, return false); // Do not mark items as changed if they actually are not: - DebuggerItem orig = debuggerItem(sitem); - if (orig == item && DebuggerItemManager::findById(orig.id())) + const DebuggerItem *orig = DebuggerItemManager::findById(item.id()); + if (orig && *orig == item) changed = false; int row = sitem->row();