feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Default to .cpp for QuickFix creation of 1-line setter/getter

Browse Source 
Until Qt Creator 4.14, the QuickFix for setter/getter creation for
simple members added the implementation in the .cpp file.

The new QuickFix settings in Qt Creator 4.15 in theory keep the default
like before, but the threshold of 2 lines is usually not reached, which
causes the getter/setter implementations to now land in the header file.

This change sets the default threshold to 1 to restore the previous
default behavior.

Fixes: QTCREATORBUG-25331
Change-Id: I570deaa8b81686dc31254e8261b59ddcf8731f91
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Alessandro Portale
2021-02-11 11:57:57 +01:00
parent 6829d92d38
commit 395e7cbfb9
2 changed files with 30 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cppeditor/cppquickfixsettings.h
View File

@@ -138,9 +138,9 @@ public:
public:
int getterOutsideClassFrom = 0;
int getterInCppFileFrom = 2;
int getterInCppFileFrom = 1;
int setterOutsideClassFrom = 0;
int setterInCppFileFrom = 2;
int setterInCppFileFrom = 1;
QString getterAttributes; // e.g. [[nodiscard]]
QString getterNameTemplate = "<name>"; // or get<Name>
QString setterNameTemplate = "set<Name>"; // or set_<name> or Set<Name>