From 396c0337074e2442dd467bd02a772b3b7689e079 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Wed, 2 Sep 2015 17:11:30 +0200 Subject: [PATCH] Project: Fix possible crash with projects without build configuration Do not allow to rename buildconfigurations if there are none. Change-Id: I3da2ea9568c2dabf555685c3b27192bea8dcc009 Reviewed-by: Eike Ziller Reviewed-by: Daniel Teske --- src/plugins/projectexplorer/buildsettingspropertiespage.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plugins/projectexplorer/buildsettingspropertiespage.cpp b/src/plugins/projectexplorer/buildsettingspropertiespage.cpp index a303b4210e2..a801ac9e271 100644 --- a/src/plugins/projectexplorer/buildsettingspropertiespage.cpp +++ b/src/plugins/projectexplorer/buildsettingspropertiespage.cpp @@ -199,7 +199,9 @@ void BuildSettingsWidget::updateBuildSettings() clearWidgets(); // update buttons - m_removeButton->setEnabled(m_target->buildConfigurations().size() > 1); + QList bcs = m_target->buildConfigurations(); + m_removeButton->setEnabled(bcs.size() > 1); + m_renameButton->setEnabled(!bcs.isEmpty()); if (!m_buildConfiguration) return; @@ -288,6 +290,7 @@ QString BuildSettingsWidget::uniqueName(const QString & name) void BuildSettingsWidget::renameConfiguration() { + QTC_ASSERT(m_buildConfiguration, return); bool ok; QString name = QInputDialog::getText(this, tr("Rename..."), tr("New name for build configuration %1:").