feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Delay creation of views until activation

Browse Source 
We don't need to waste the time and memory required to create the views
if they are never shown.

Change-Id: I56add08981c90263e6735f5b7e6fac2140b457e4
Fixes: QTCREATORBUG-21894
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Ulf Hermann
2019-01-28 09:10:46 +01:00
parent 7a5198e867
commit 39eec848ce
5 changed files with 29 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/qmlprofiler/qmlprofilertextmark.cpp
View File

@@ -52,11 +52,14 @@ void QmlProfilerTextMark::addTypeId(int typeId)
void QmlProfilerTextMark::paintIcon(QPainter *painter, const QRect &paintRect) const
{
const QmlProfilerStatisticsView *statisticsView = m_viewManager->statisticsView();
QTC_ASSERT(statisticsView, return);
painter->save();
painter->setPen(Qt::black);
painter->fillRect(paintRect, Qt::white);
painter->drawRect(paintRect);
painter->drawText(paintRect, m_viewManager->statisticsView()->summary(m_typeIds),
painter->drawText(paintRect, statisticsView->summary(m_typeIds),
Qt::AlignRight | Qt::AlignVCenter);
painter->restore();
}
@@ -133,10 +136,13 @@ void QmlProfilerTextMarkModel::hideTextMarks()
bool QmlProfilerTextMark::addToolTipContent(QLayout *target) const
{
const QmlProfilerStatisticsView *statisticsView = m_viewManager->statisticsView();
QTC_ASSERT(statisticsView, return false);
auto layout = new QGridLayout;
layout->setHorizontalSpacing(10);
for (int row = 0, rowEnd = m_typeIds.length(); row != rowEnd; ++row) {
const QStringList typeDetails = m_viewManager->statisticsView()->details(m_typeIds[row]);
const QStringList typeDetails = statisticsView->details(m_typeIds[row]);
for (int column = 0, columnEnd = typeDetails.length(); column != columnEnd; ++column) {
QLabel *label = new QLabel;
label->setAlignment(column == columnEnd - 1 ? Qt::AlignRight : Qt::AlignLeft);