feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Merge GDB/LLDB process error handling

Browse Source 
This also removes some of the "illegal" state transitions,
partially addressing QTCREATORBUG-14089.

Change-Id: I817d87a0b5e0a40285bc9b0880fef5bceaee3f16
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
hjk
2015-03-05 11:11:32 +01:00
parent 4d2359443f
commit 39f904957a
6 changed files with 42 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -4366,33 +4366,12 @@ void GdbEngine::handleGdbError(QProcess::ProcessError error)
}
}
void GdbEngine::handleGdbFinished(int code, QProcess::ExitStatus type)
void GdbEngine::handleGdbFinished(int exitCode, QProcess::ExitStatus exitStatus)
{
if (m_commandTimer.isActive())
m_commandTimer.stop();
showMessage(_("GDB PROCESS FINISHED, status %1, code %2").arg(type).arg(code));
switch (state()) {
case EngineShutdownRequested:
notifyEngineShutdownOk();
break;
case InferiorRunOk:
// This could either be a real gdb crash or a quickly exited inferior
// in the terminal adapter. In this case the stub proc will die soon,
// too, so there's no need to act here.
showMessage(_("The gdb process exited somewhat unexpectedly."));
notifyEngineSpontaneousShutdown();
break;
default: {
notifyEngineIll(); // Initiate shutdown sequence
const QString msg = type == QProcess::CrashExit ?
tr("The gdb process terminated.") :
tr("The gdb process terminated unexpectedly (code %1)").arg(code);
AsynchronousMessageBox::critical(tr("Unexpected GDB Exit"), msg);
break;
}
}
notifyDebuggerProcessFinished(exitCode, exitStatus, QLatin1String("GDB"));
}
void GdbEngine::abortDebugger()