From 3a09687921bc4a6937dcca34dfc09e8b6dda6db9 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Thu, 4 Oct 2018 11:02:26 +0200 Subject: [PATCH] Menu locator filter: Fix that e.g. recent files were no longer available Amends aed2c2c716d64163466827d7503c39819bc4ff45 After checking which actions are enabled we may not trigger the menus' aboutToShow anymore, since this can completely rebuild the menu including recreating the actions. We also don't have to, since this moved to before checking which actions are enabled. Change-Id: I1108edce0818f71080b2926a1121c45de38672e1 Reviewed-by: David Schulz --- src/plugins/coreplugin/menubarfilter.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plugins/coreplugin/menubarfilter.cpp b/src/plugins/coreplugin/menubarfilter.cpp index 69c178ae94c..7791bb1f1ef 100644 --- a/src/plugins/coreplugin/menubarfilter.cpp +++ b/src/plugins/coreplugin/menubarfilter.cpp @@ -190,8 +190,6 @@ void Core::Internal::MenuBarFilter::prepareSearch(const QString &entry) const QStringList entryPath = normalized.split(separators.at(0), QString::SkipEmptyParts); m_entries.clear(); QVector processedMenus; - for (QAction* action : menuBarActions()) { - requestMenuUpdate(action); + for (QAction* action : menuBarActions()) m_entries << matchesForAction(action, entryPath, QStringList(), processedMenus); - } }