feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Do not crash when clicking in empty line of HistoryCompleter

Browse Source 
Removing lines from a HistoryCompleter can result in a crash if the
mouse click happens on an empty line.

Change-Id: I02ee7c4705e1a4bc6b63ccdae207b5078b03360e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Christian Stenger
2018-12-03 09:35:44 +01:00
parent b79c0628e5
commit 3a4a53ee1c
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/libs/utils/historycompleter.cpp
View File

@@ -117,8 +117,11 @@ private:
if (layoutDirection() == Qt::LeftToRight) if (layoutDirection() == Qt::LeftToRight)
rr = viewport()->width() - event->x(); rr = viewport()->width() - event->x();
if (rr < clearButtonSize.width()) { if (rr < clearButtonSize.width()) {
model->removeRow(indexAt(event->pos()).row()); const QModelIndex index = indexAt(event->pos());
return; if (index.isValid()) {
model->removeRow(indexAt(event->pos()).row());
return;
}
} }
} }
QListView::mousePressEvent(event); QListView::mousePressEvent(event);