forked from qt-creator/qt-creator
VCS: Colorize unmerged files in submit editor
So far, conflicted files were displayed like added ones. Now they are marked obvious, as they disable the commit button. Task-number: QTCREATORBUG-16297 Change-Id: Iedf834408a747c4fe5f2133790c5fb81e7fea265 Reviewed-by: Hugues Delorme <delorme.hugues@fougue.pro> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
committed by
Orgad Shaneh
parent
67f9a26208
commit
3a78b610d7
@@ -164,6 +164,7 @@ VcsBase_FileAdded_TextColor=ff00ff00
|
|||||||
VcsBase_FileModified_TextColor=ff8ee0ff
|
VcsBase_FileModified_TextColor=ff8ee0ff
|
||||||
VcsBase_FileDeleted_TextColor=fffff6c6c
|
VcsBase_FileDeleted_TextColor=fffff6c6c
|
||||||
VcsBase_FileRenamed_TextColor=ffffa500
|
VcsBase_FileRenamed_TextColor=ffffa500
|
||||||
|
VcsBase_FileUnmerged_TextColor=ffff4040
|
||||||
|
|
||||||
Bookmarks_TextMarkColor=ff8080ff
|
Bookmarks_TextMarkColor=ff8080ff
|
||||||
|
|
||||||
|
|||||||
@@ -156,8 +156,9 @@ Welcome_LinkColor=ff5caa15
|
|||||||
VcsBase_FileStatusUnknown_TextColor=ff000000
|
VcsBase_FileStatusUnknown_TextColor=ff000000
|
||||||
VcsBase_FileAdded_TextColor=ff00aa00
|
VcsBase_FileAdded_TextColor=ff00aa00
|
||||||
VcsBase_FileModified_TextColor=ff0000ee
|
VcsBase_FileModified_TextColor=ff0000ee
|
||||||
VcsBase_FileDeleted_TextColor=ffee0000
|
VcsBase_FileDeleted_TextColor=ff800000
|
||||||
VcsBase_FileRenamed_TextColor=ffd77d00
|
VcsBase_FileRenamed_TextColor=ffd77d00
|
||||||
|
VcsBase_FileUnmerged_TextColor=ffee0000
|
||||||
|
|
||||||
Bookmarks_TextMarkColor=ffa0a0ff
|
Bookmarks_TextMarkColor=ffa0a0ff
|
||||||
|
|
||||||
|
|||||||
@@ -166,8 +166,9 @@ Welcome_LinkColor=ff5caa15
|
|||||||
VcsBase_FileStatusUnknown_TextColor=ff000000
|
VcsBase_FileStatusUnknown_TextColor=ff000000
|
||||||
VcsBase_FileAdded_TextColor=ff00aa00
|
VcsBase_FileAdded_TextColor=ff00aa00
|
||||||
VcsBase_FileModified_TextColor=ff0000ee
|
VcsBase_FileModified_TextColor=ff0000ee
|
||||||
VcsBase_FileDeleted_TextColor=ffee0000
|
VcsBase_FileDeleted_TextColor=ff800000
|
||||||
VcsBase_FileRenamed_TextColor=ffd77d00
|
VcsBase_FileRenamed_TextColor=ffd77d00
|
||||||
|
VcsBase_FileUnmerged_TextColor=ffee0000
|
||||||
|
|
||||||
Bookmarks_TextMarkColor=ffa0a0ff
|
Bookmarks_TextMarkColor=ffa0a0ff
|
||||||
|
|
||||||
|
|||||||
@@ -215,6 +215,7 @@ public:
|
|||||||
VcsBase_FileModified_TextColor,
|
VcsBase_FileModified_TextColor,
|
||||||
VcsBase_FileDeleted_TextColor,
|
VcsBase_FileDeleted_TextColor,
|
||||||
VcsBase_FileRenamed_TextColor,
|
VcsBase_FileRenamed_TextColor,
|
||||||
|
VcsBase_FileUnmerged_TextColor,
|
||||||
|
|
||||||
/* Bookmarks Plugin */
|
/* Bookmarks Plugin */
|
||||||
Bookmarks_TextMarkColor,
|
Bookmarks_TextMarkColor,
|
||||||
|
|||||||
@@ -142,6 +142,8 @@ void GitSubmitEditor::setCommitData(const CommitData &d)
|
|||||||
-> SubmitFileModel::FileStatusHint
|
-> SubmitFileModel::FileStatusHint
|
||||||
{
|
{
|
||||||
const FileStates state = static_cast<FileStates>(extraData.toInt());
|
const FileStates state = static_cast<FileStates>(extraData.toInt());
|
||||||
|
if (state & (UnmergedFile | UnmergedThem | UnmergedUs))
|
||||||
|
return SubmitFileModel::FileUnmerged;
|
||||||
if (state.testFlag(AddedFile) || state.testFlag(UntrackedFile))
|
if (state.testFlag(AddedFile) || state.testFlag(UntrackedFile))
|
||||||
return SubmitFileModel::FileAdded;
|
return SubmitFileModel::FileAdded;
|
||||||
if (state.testFlag(ModifiedFile))
|
if (state.testFlag(ModifiedFile))
|
||||||
|
|||||||
@@ -48,6 +48,8 @@ void SubversionSubmitEditor::setStatusList(const QList<StatusFilePair> &statusOu
|
|||||||
model->setFileStatusQualifier([](const QString &status, const QVariant &)
|
model->setFileStatusQualifier([](const QString &status, const QVariant &)
|
||||||
-> VcsBase::SubmitFileModel::FileStatusHint
|
-> VcsBase::SubmitFileModel::FileStatusHint
|
||||||
{
|
{
|
||||||
|
if (status == QLatin1String("C"))
|
||||||
|
return VcsBase::SubmitFileModel::FileUnmerged;
|
||||||
if (status == QLatin1String("A"))
|
if (status == QLatin1String("A"))
|
||||||
return VcsBase::SubmitFileModel::FileAdded;
|
return VcsBase::SubmitFileModel::FileAdded;
|
||||||
if (status == QLatin1String("M"))
|
if (status == QLatin1String("M"))
|
||||||
|
|||||||
@@ -61,6 +61,9 @@ static QBrush fileStatusTextForeground(SubmitFileModel::FileStatusHint statusHin
|
|||||||
case SubmitFileModel::FileRenamed:
|
case SubmitFileModel::FileRenamed:
|
||||||
statusTextColor = Theme::VcsBase_FileRenamed_TextColor;
|
statusTextColor = Theme::VcsBase_FileRenamed_TextColor;
|
||||||
break;
|
break;
|
||||||
|
case VcsBase::SubmitFileModel::FileUnmerged:
|
||||||
|
statusTextColor = Theme::VcsBase_FileUnmerged_TextColor;
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
return QBrush(Utils::creatorTheme()->color(statusTextColor));
|
return QBrush(Utils::creatorTheme()->color(statusTextColor));
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -75,7 +75,8 @@ public:
|
|||||||
FileAdded,
|
FileAdded,
|
||||||
FileModified,
|
FileModified,
|
||||||
FileDeleted,
|
FileDeleted,
|
||||||
FileRenamed
|
FileRenamed,
|
||||||
|
FileUnmerged
|
||||||
};
|
};
|
||||||
|
|
||||||
// Function that converts(qualifies) a QString/QVariant pair to FileStatusHint
|
// Function that converts(qualifies) a QString/QVariant pair to FileStatusHint
|
||||||
|
|||||||
Reference in New Issue
Block a user