feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Pedantic cleanup of filename parameters for QIcon constructor

Browse Source 
Using more *::Constants::ICON_* where it makes sense and
wrapping the file names into QLatin1String where they were
missing.

The increased usage of the ICON constants needed a few more
cross plugin includes of *constants.h, here and there.
I think that it is OK, since the dependencies were alredy there
icon resource wise.
This commit is contained in:
Alessandro Portale
2010-07-30 22:16:59 +02:00
parent e55c346f03
commit 3aa3c5688f
48 changed files with 131 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/texteditor/outlinefactory.cpp
View File

@@ -1,4 +1,5 @@
#include "outlinefactory.h"
#include <coreplugin/coreconstants.h>
#include <coreplugin/icore.h>
#include <coreplugin/editormanager/editormanager.h>
#include <coreplugin/editormanager/ieditor.h>
@@ -27,14 +28,14 @@ OutlineWidgetStack::OutlineWidgetStack(OutlineFactory *factory) :
addWidget(label);
m_toggleSync = new QToolButton;
m_toggleSync->setIcon(QIcon(":/core/images/linkicon.png"));
m_toggleSync->setIcon(QIcon(QLatin1String(Core::Constants::ICON_LINK)));
m_toggleSync->setCheckable(true);
m_toggleSync->setChecked(true);
m_toggleSync->setToolTip(tr("Synchronize with Editor"));
connect(m_toggleSync, SIGNAL(clicked(bool)), this, SLOT(toggleCursorSynchronization()));
m_filterButton = new QToolButton;
m_filterButton->setIcon(QIcon(":/core/images/filtericon.png"));
m_filterButton->setIcon(QIcon(QLatin1String(Core::Constants::ICON_FILTER)));
m_filterButton->setToolTip(tr("Filter tree"));
m_filterButton->setPopupMode(QToolButton::InstantPopup);
m_filterMenu = new QMenu(m_filterButton);