From 3b545319b72318051bca432d10c03fc7b7471caf Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Fri, 24 Apr 2015 12:03:08 +0200 Subject: [PATCH] About Plugins: Fix that disabling plugin could disable too many others Only disable plugin rows with disabled *Required* plugin dependencies. Change 044eeacde5ee1add8b06a8a53b86fd5c6991d488 introduces another dependency type "Test", which are actually not dependencies in a strict sense and even can be cyclic, which makes this bug especially obvious. Change-Id: Ie504b4dd52670d838b712e88ae2e42123975b1d5 Reviewed-by: Orgad Shaneh Reviewed-by: hjk --- src/libs/extensionsystem/pluginview.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libs/extensionsystem/pluginview.cpp b/src/libs/extensionsystem/pluginview.cpp index 9875a3d5d3b..dab73b179e3 100644 --- a/src/libs/extensionsystem/pluginview.cpp +++ b/src/libs/extensionsystem/pluginview.cpp @@ -343,6 +343,8 @@ static void queryDependendPlugins(PluginSpec *spec, QSet *dependen QHashIterator it(spec->dependencySpecs()); while (it.hasNext()) { it.next(); + if (it.key().type != PluginDependency::Required) + continue; PluginSpec *dep = it.value(); if (!dependencies->contains(dep)) { dependencies->insert(dep);