feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Modernize

Browse Source 
modernize-use-using
modernize-use-default-member-init
modernize-use-equals-default

Change-Id: Iaccd5611cfc2056d357a0545f8522f02d6f8f0ed
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Alessandro Portale
2018-11-10 18:29:32 +01:00
parent 96529a27c5
commit 3b6f45a7a3
10 changed files with 17 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/git/gerrit/gerritmodel.cpp
View File

@@ -140,9 +140,9 @@ static inline void applyApproval(int approval, int *total)
// by a type character followed by the approval level: "C: -2, S: 1"
QString GerritPatchSet::approvalsColumn() const
{
typedef QMap<QChar, int> TypeReviewMap;
typedef TypeReviewMap::iterator TypeReviewMapIterator;
typedef TypeReviewMap::const_iterator TypeReviewMapConstIterator;
using TypeReviewMap = QMap<QChar, int>;
using TypeReviewMapIterator = TypeReviewMap::iterator;
using TypeReviewMapConstIterator = TypeReviewMap::const_iterator;
QString result;
if (approvals.isEmpty())
@@ -398,8 +398,7 @@ GerritModel::GerritModel(const QSharedPointer<GerritParameters> &p, QObject *par
setHorizontalHeaderLabels(headers);
}
GerritModel::~GerritModel()
{ }
GerritModel::~GerritModel() = default;
QVariant GerritModel::data(const QModelIndex &index, int role) const
{