feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Fix handling of test cases with comma

Browse Source 
Fixes: QTCREATORBUG-27705
Change-Id: I6e22df4e401dc52e8d8599cc8b4de16200093b03
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2022-06-10 10:17:20 +02:00
parent a91043d8ba
commit 3b7029fbdc
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/autotest/catch/catchconfiguration.cpp
View File

@@ -98,7 +98,7 @@ QStringList CatchConfiguration::argumentsForTestRunner(QStringList *omitted) con
{ {
QStringList arguments; QStringList arguments;
if (testCaseCount()) if (testCaseCount())
arguments << "\"" + testCases().join("\",\"") + "\""; arguments << "\"" + testCases().join("\", \"") + "\"";
arguments << "--reporter" << "xml"; arguments << "--reporter" << "xml";
if (AutotestPlugin::settings()->processArgs) { if (AutotestPlugin::settings()->processArgs) {

4
src/plugins/autotest/catch/catchtreeitem.cpp
View File

@@ -37,7 +37,9 @@ namespace Internal {
QString CatchTreeItem::testCasesString() const QString CatchTreeItem::testCasesString() const
{ {
return m_state & CatchTreeItem::Parameterized ? QString(name() + " -*") : name(); QString testcase = m_state & CatchTreeItem::Parameterized ? QString(name() + " -*") : name();
// mask comma if it is part of the test case name
return testcase.replace(',', "\\,");
} }
static QString nonRootDisplayName(const CatchTreeItem *it) static QString nonRootDisplayName(const CatchTreeItem *it)