feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Make LayoutBuilder::Setter a LayoutItem

Browse Source 
Weird, but makes GroupBox implementation less special and allows
several setters without resorting to using extra {...} there,
which would be needed e.g. for title _and_ toolTip.

Change-Id: Ie0e64a7bae15825292a473a1e973817be5c27fc4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
hjk
2022-08-10 17:13:21 +02:00
parent 11648298c8
commit 3c9aa364ec
2 changed files with 26 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/libs/utils/layoutbuilder.cpp
View File

@@ -467,23 +467,31 @@ namespace Layouting {
// "Widgets"
Group::Group(const LayoutBuilder &innerLayout)
: Group({}, innerLayout)
{}
Group::Group(const LayoutBuilder::Setters &setters, const LayoutBuilder &innerLayout)
static void applyItems(QWidget *widget, const QList<LayoutBuilder::LayoutItem> &items)
{
widget = new QGroupBox;
innerLayout.attachTo(widget, AttachType::WithMargins);
for (const LayoutBuilder::Setter &func : setters)
func(widget);
bool hadLayout = false;
for (const LayoutBuilder::LayoutItem &item : items) {
if (item.setter) {
item.setter(widget);
} else if (item.layout && !hadLayout) {
hadLayout = true;
widget->setLayout(item.layout);
} else {
QTC_CHECK(false);
}
}
}
PushButton::PushButton(std::initializer_list<LayoutBuilder::Setter> setters)
Group::Group(std::initializer_list<LayoutBuilder::LayoutItem> items)
{
widget = new QGroupBox;
applyItems(widget, items);
}
PushButton::PushButton(std::initializer_list<LayoutBuilder::LayoutItem> items)
{
widget = new QPushButton;
for (const LayoutBuilder::Setter &func : setters)
func(widget);
applyItems(widget, items);
}
// "Properties"