From 3cdb35dc4add0d22c73625e6ed02f0712e49dac6 Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Fri, 19 Oct 2018 07:05:46 +0200 Subject: [PATCH] LSP: Restart client if language filter settings change Alternative way to the more complex way of de-registering opened documents from the respective client that do no more match the language filter settings. Change-Id: I1968a928480e49cf203b91d7d36cf7db26f6d56c Reviewed-by: David Schulz --- src/plugins/languageclient/baseclient.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/plugins/languageclient/baseclient.cpp b/src/plugins/languageclient/baseclient.cpp index f2451bdc420..6756ec9db7c 100644 --- a/src/plugins/languageclient/baseclient.cpp +++ b/src/plugins/languageclient/baseclient.cpp @@ -515,9 +515,11 @@ bool BaseClient::isSupportedDocument(const Core::IDocument *document) const }); } -bool BaseClient::needsRestart(const BaseSettings *) const +bool BaseClient::needsRestart(const BaseSettings *settings) const { - return false; + QTC_ASSERT(settings, return false); + return m_languagFilter.mimeTypes != settings->m_languageFilter.mimeTypes + || m_languagFilter.filePattern != settings->m_languageFilter.filePattern; } bool BaseClient::reset()